legacy-support: Circular dependency with clang

[ryandesign (Ryan Carsten Schmidt)]

I can't update the ports installed on the 10.6 buildbot worker machines because of what looks like a circular dependency of sorts.

$ sudo port upgrade llvm-9.0
--->  Computing dependencies for legacy-support
--->  Fetching distfiles for legacy-support
--->  Verifying checksums for legacy-support
--->  Extracting legacy-support
--->  Configuring legacy-support
--->  Building legacy-support
Error: Failed to build legacy-support: command execution failed

In the log:

:info:build /opt/bblocal/bin/clang-mp-9.0 -c -Iinclude -Os -arch x86_64 -fPIC src/arc4random.c -o src/arc4random.dl.o
:info:build dyld: Library not loaded: /opt/bblocal/lib/libffi.6.dylib
:info:build   Referenced from: /opt/bblocal/libexec/llvm-9.0/bin/../lib/libLLVM.dylib
:info:build   Reason: image not found
:info:build make: *** [src/arc4random.dl.o] Trace/BPT trap

[ryandesign (Ryan Carsten Schmidt)]

llvm-9.0 depends on cmake, cmake needs legacy-support, legacy-support builds with clang-9.0 which depends on llvm-9.0.

Does legacy-support need PortGroup clang_dependency 1.0?

[ryandesign (Ryan Carsten Schmidt)]

Adding that does seem to fix the problem and allow legacy-support to build with clang-3.7 instead.

[jmroot (Joshua Root)]

Yes, everything that clang has a dependency on needs to use the clang_dependency portgroup.

[jmroot (Joshua Root)]

Sorry, posting that comment at the same time you posted yours seems to have undone your other changes.

[kencu (Ken)]

Yeah, guess I missed that path when I removed that recently.

I have a local PR that removes cmake and all the cmake deps from this and uses cmake-bootstrap to fix this up, but never pushed it.

I'd prefer to get much of this stuff out of the clang dependency group.

[kencu (Ken)]

[415e4948bca162c2088bf3bdc308d4079a296e16/macports-ports]