Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#61454 closed defect (fixed)

samba3 3.6.25_3: gettimeofday wrong

Reported by: MaddTheSane (C.W. Betts) Owned by: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Priority: Normal Milestone:
Component: ports Version: 2.6.4
Keywords: Cc: ballapete (Peter "Pete" Dyballa), eschnett (Erik Schnetter), juanalexei, wahspilihp (Philip Shaw), Guymer (Thomas Guymer), ShadSterling (Shad Sterling), olupton (Olli Lupton), dliessi (Davide Liessi), captainproton1971 (Captain Proton), azakru, MarcusCalhoun-Lopez (Marcus Calhoun-Lopez), mascguy (Christopher Nielsen)
Port: samba3

Description (last modified by MaddTheSane (C.W. Betts))

When building samba3 (as required by ffmpeg +gpl3), it fails to build due to an improper call to gettimeofday: 

:info:build ../lib/util/time.c:56:19: error: too few arguments to function call, expected 2, have 1
:info:build         gettimeofday(tval);
:info:build         ~~~~~~~~~~~~     ^

Attachments (1)

main.log​ (656.2 KB) - added by MaddTheSane (C.W. Betts) 4 years ago.
Build log

Download all attachments as: .zip

Change History (21)

Changed 4 years ago by MaddTheSane (C.W. Betts)

Attachment: main.log​ added

Build log

comment:1 Changed 4 years ago by MaddTheSane (C.W. Betts)

Description: modified (diff)

comment:2 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Probably because: 

:info:configure checking if gettimeofday takes TZ argument... no

Which is probably because that check and many others failed to make the correct determination because of errors like: 

conftest.c:157:29: error: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Werror,-Wimplicit-function-declaration]

comment:3 Changed 4 years ago by ballapete (Peter "Pete" Dyballa)

Cc: ballapete added

comment:4 Changed 4 years ago by ballapete (Peter "Pete" Dyballa)

On Big Sur, macOS Version 11.0.1, another problem exists: 

checking for perl... /opt/local/bin/perl
checking for python2.6... no
checking for python2.5... no
checking for python2.4... no
checking for python... /opt/local/bin/python
checking for python2.6-config... no
checking for python2.5-config... no
checking for python2.4-config... no
checking for python-config... /opt/local/bin/python-config
  File "<string>", line 1
    from distutils import sysconfig;                                          print '-I%s -I%s %s' % (                                                  sysconfig.get_python_inc(),                                                     sysconfig.get_pytho\
n_inc(plat_specific=1),                                                      sysconfig.get_config_var('CFLAGS'))
                                                      ^
SyntaxError: invalid syntax
  File "<string>", line 1
    from distutils import sysconfig;                                           print '%s %s -lpython%s -L%s %s -L%s' % (                                                        sysconfig.get_config_var('LIBS'),                                          \
             sysconfig.get_config_var('SYSLIBS'),                                                    sysconfig.get_config_var('VERSION'),                                                    sysconfig.get_config_var('LIBDIR'),                           \
                          sysconfig.get_config_var('LDFLAGS'),                                                    sysconfig.get_config_var('LIBPL'))
                                                       ^
SyntaxError: invalid syntax
Traceback (most recent call last):
  File "<string>", line 1, in <module>
AttributeError: 'sys.version_info' object has no attribute '__getslice__'
checking working python module support... no
checking for ar... ar

Only python38 @3.8.6_0+optimizations (active) is installed.

comment:5 in reply to:  4 ; Changed 4 years ago by ballapete (Peter "Pete" Dyballa)

/opt/local/bin/python-config is a symbolic link that was left from Catalina and was not removed when upgrading to Big Sur (port provides /opt/local/bin/python-config reports: "… is not provided by a MacPorts port"). At least it pointed to /opt/local/bin/python3.8-config, the up-to-date version of Python. Without this link configure finds python-config... /usr/bin/python-config – Python 2.7. With the same failure: 

  File "<string>", line 1
    from distutils import sysconfig;                                          print '-I%s -I%s %s' % (                                                  sysconfig.get_python_inc(),                                                     sysconfig.get_python_inc(plat_specific=1),                        \
                              sysconfig.get_config_var('CFLAGS'))
                                                      ^
SyntaxError: invalid syntax
  File "<string>", line 1
    from distutils import sysconfig;                                           print '%s %s -lpython%s -L%s %s -L%s' % (                                                        sysconfig.get_config_var('LIBS'),                                                       sysconfig.get_config_var('SYSLIBS'\
),                                                    sysconfig.get_config_var('VERSION'),                                                    sysconfig.get_config_var('LIBDIR'),                                                     sysconfig.get_config_var('LDFLAGS'),                                \
                    sysconfig.get_config_var('LIBPL'))
                                                       ^
SyntaxError: invalid syntax
Traceback (most recent call last):
  File "<string>", line 1, in <module>
AttributeError: 'sys.version_info' object has no attribute '__getslice__'
checking working python module support... no

Is configure faulty?

comment:6 in reply to:  5 Changed 4 years ago by ballapete (Peter "Pete" Dyballa)

Replying to ballapete:

Is configure faulty?

Yes, it seems so: 

configure:7348: result: /opt/local/bin/python-config
configure:7430: /usr/bin/clang -o conftest -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -arch x86_64 -I/opt/local/Library/Frameworks/Python.framework/Versions/3.8/include/python3.8 -I/opt/local/Library/Frameworks/Python.framework/Versions/3.8/include/python3.8 -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -L/opt/local/lib -Wl,-headerpad_max_install_names -lintl -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -arch x86_64 conftest.c  -L/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/config-3.8-darwin -ldl -framework CoreFoundation >&5
conftest.c:51:5: error: implicit declaration of function 'Py_InitModule' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                                Py_InitModule(NULL, NULL);
                                ^
1 error generated.
configure:7430: $? = 1
configure: failed program was:
| /* confdefs.h */
| #define PACKAGE_NAME "Samba"
| #define PACKAGE_TARNAME "samba"
| #define PACKAGE_VERSION "3"
| #define PACKAGE_STRING "Samba 3"
| #define PACKAGE_BUGREPORT "samba-technical@samba.org"
| #define PACKAGE_URL ""
| #define CONFIG_H_IS_FROM_SAMBA 1
| #define STDC_HEADERS 1
| #define HAVE_SYS_TYPES_H 1
| #define HAVE_SYS_STAT_H 1
| #define HAVE_STDLIB_H 1
| #define HAVE_STRING_H 1
| #define HAVE_MEMORY_H 1
| #define HAVE_STRINGS_H 1
| #define HAVE_INTTYPES_H 1
| #define HAVE_STDINT_H 1
| #define HAVE_UNISTD_H 1
| #define __EXTENSIONS__ 1
| #define _ALL_SOURCE 1
| #define _GNU_SOURCE 1
| #define _POSIX_PTHREAD_SEMANTICS 1
| #define _TANDEM_SOURCE 1
| #ifndef _XOPEN_SOURCE_EXTENDED
| #define _XOPEN_SOURCE_EXTENDED 1
| #endif
| #define HAVE_STANDARDS_H 1
| #define HAVE_LONG_LONG 1
| #define SIZEOF_INT 4
| #define SIZEOF_CHAR 1
| #define SIZEOF_SHORT 2
| #define SIZEOF_LONG 8
| #define SIZEOF_LONG_LONG 8
| #define SIZEOF_OFF_T 8
| #define SIZEOF_SIZE_T 8
| #define SIZEOF_SSIZE_T 8
| #define HAVE_INTPTR_T 1
| #define HAVE_UINTPTR_T 1
| #define HAVE_PTRDIFF_T 1
| #define HAVE_IMMEDIATE_STRUCTURES 1
| /* end confdefs.h.  */
| 
|                                 #undef HAVE_UINTPTR_T
| 				/* we have our own configure tests */
| 				#include <Python.h>
| 
| int
| main ()
| {
| 
| 				Py_InitModule(NULL, NULL);
| 
|   ;
|   return 0;
| }
configure:7467: /usr/bin/clang -o conftest -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -arch x86_64 -I/opt/local/Library/Frameworks/Python.framework/Versions/3.8/include/python3.8 -I/opt/local/Library/Frameworks/Python.framework/Versions/3.8/include/python3.8 -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -L/opt/local/lib -Wl,-headerpad_max_install_names -lintl -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -arch x86_64 conftest.c  -L/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/config-3.8-darwin -ldl -framework CoreFoundation >&5
conftest.c:51:5: error: implicit declaration of function 'Py_InitModule' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                                Py_InitModule(NULL, NULL);
                                ^
1 error generated.
configure:7467: $? = 1
configure: failed program was:
| /* confdefs.h */
| #define PACKAGE_NAME "Samba"
| #define PACKAGE_TARNAME "samba"
| #define PACKAGE_VERSION "3"
| #define PACKAGE_STRING "Samba 3"
| #define PACKAGE_BUGREPORT "samba-technical@samba.org"
| #define PACKAGE_URL ""
| #define CONFIG_H_IS_FROM_SAMBA 1
| #define STDC_HEADERS 1
| #define HAVE_SYS_TYPES_H 1
| #define HAVE_SYS_STAT_H 1
| #define HAVE_STDLIB_H 1
| #define HAVE_STRING_H 1
| #define HAVE_MEMORY_H 1
| #define HAVE_STRINGS_H 1
| #define HAVE_INTTYPES_H 1
| #define HAVE_STDINT_H 1
| #define HAVE_UNISTD_H 1
| #define __EXTENSIONS__ 1
| #define _ALL_SOURCE 1
| #define _GNU_SOURCE 1
| #define _POSIX_PTHREAD_SEMANTICS 1
| #define _TANDEM_SOURCE 1
| #ifndef _XOPEN_SOURCE_EXTENDED
| #define _XOPEN_SOURCE_EXTENDED 1
| #endif
| #define HAVE_STANDARDS_H 1
| #define HAVE_LONG_LONG 1
| #define SIZEOF_INT 4
| #define SIZEOF_CHAR 1
| #define SIZEOF_SHORT 2
| #define SIZEOF_LONG 8
| #define SIZEOF_LONG_LONG 8
| #define SIZEOF_OFF_T 8
| #define SIZEOF_SIZE_T 8
| #define SIZEOF_SSIZE_T 8
| #define HAVE_INTPTR_T 1
| #define HAVE_UINTPTR_T 1
| #define HAVE_PTRDIFF_T 1
| #define HAVE_IMMEDIATE_STRUCTURES 1
| /* end confdefs.h.  */
| 
|                                 #undef HAVE_UINTPTR_T
| 				/* we have our own configure tests */
| 				#include <Python.h>
| 
| int
| main ()
| {
| 
| 				Py_InitModule(NULL, NULL);
| 
|   ;
|   return 0;
| }
configure:7507: /usr/bin/clang -o conftest -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -arch x86_64 -I/opt/local/Library/Frameworks/Python.framework/Versions/3.8/include/python3.8 -I/opt/local/Library/Frameworks/Python.framework/Versions/3.8/include/python3.8 -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -L/opt/local/lib -Wl,-headerpad_max_install_names -lintl -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -arch x86_64 conftest.c  -n -L/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib  
-L/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/config-3.8-darwin -ldl -framework CoreFoundation >&5
clang: error: unknown argument: '-n'
configure:7507: $? = 1
configure: failed program was:
| /* confdefs.h */
| #define PACKAGE_NAME "Samba"
| #define PACKAGE_TARNAME "samba"
| #define PACKAGE_VERSION "3"
| #define PACKAGE_STRING "Samba 3"
| #define PACKAGE_BUGREPORT "samba-technical@samba.org"
| #define PACKAGE_URL ""
| #define CONFIG_H_IS_FROM_SAMBA 1
| #define STDC_HEADERS 1
| #define HAVE_SYS_TYPES_H 1
| #define HAVE_SYS_STAT_H 1
| #define HAVE_STDLIB_H 1
| #define HAVE_STRING_H 1
| #define HAVE_MEMORY_H 1
| #define HAVE_STRINGS_H 1
| #define HAVE_INTTYPES_H 1
| #define HAVE_STDINT_H 1
| #define HAVE_UNISTD_H 1
| #define __EXTENSIONS__ 1
| #define _ALL_SOURCE 1
| #define _GNU_SOURCE 1
| #define _POSIX_PTHREAD_SEMANTICS 1
| #define _TANDEM_SOURCE 1
| #ifndef _XOPEN_SOURCE_EXTENDED
| #define _XOPEN_SOURCE_EXTENDED 1
| #endif
| #define HAVE_STANDARDS_H 1
| #define HAVE_LONG_LONG 1
| #define SIZEOF_INT 4
| #define SIZEOF_CHAR 1
| #define SIZEOF_SHORT 2
| #define SIZEOF_LONG 8
| #define SIZEOF_LONG_LONG 8
| #define SIZEOF_OFF_T 8
| #define SIZEOF_SIZE_T 8
| #define SIZEOF_SSIZE_T 8
| #define HAVE_INTPTR_T 1
| #define HAVE_UINTPTR_T 1
| #define HAVE_PTRDIFF_T 1
| #define HAVE_IMMEDIATE_STRUCTURES 1
| /* end confdefs.h.  */
| 
|                                 #undef HAVE_UINTPTR_T
| 				/* we have our own configure tests */
| 				#include <Python.h>
| 
| int
| main ()
| {
| 
| 				Py_InitModule(NULL, NULL);
| 
|   ;
|   return 0;
| }
configure:7544: /usr/bin/clang -o conftest -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -arch x86_64 -I/opt/local/Library/Frameworks/Python.framework/Versions/3.8/include/python3.8 -I/opt/local/Library/Frameworks/Python.framework/Versions/3.8/include/python3.8 -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -L/opt/local/lib -Wl,-headerpad_max_install_names -lintl -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -arch x86_64 conftest.c  -n -L/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib  
-L/opt/local/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/config-3.8-darwin -ldl -framework CoreFoundation >&5
clang: error: unknown argument: '-n'
configure:7544: $? = 1
configure: failed program was:
| /* confdefs.h */
| #define PACKAGE_NAME "Samba"
| #define PACKAGE_TARNAME "samba"
| #define PACKAGE_VERSION "3"
| #define PACKAGE_STRING "Samba 3"
| #define PACKAGE_BUGREPORT "samba-technical@samba.org"
| #define PACKAGE_URL ""
| #define CONFIG_H_IS_FROM_SAMBA 1
| #define STDC_HEADERS 1
| #define HAVE_SYS_TYPES_H 1
| #define HAVE_SYS_STAT_H 1
| #define HAVE_STDLIB_H 1
| #define HAVE_STRING_H 1
| #define HAVE_MEMORY_H 1
| #define HAVE_STRINGS_H 1
| #define HAVE_INTTYPES_H 1
| #define HAVE_STDINT_H 1
| #define HAVE_UNISTD_H 1
| #define __EXTENSIONS__ 1
| #define _ALL_SOURCE 1
| #define _GNU_SOURCE 1
| #define _POSIX_PTHREAD_SEMANTICS 1
| #define _TANDEM_SOURCE 1
| #ifndef _XOPEN_SOURCE_EXTENDED
| #define _XOPEN_SOURCE_EXTENDED 1
| #endif
| #define HAVE_STANDARDS_H 1
| #define HAVE_LONG_LONG 1
| #define SIZEOF_INT 4
| #define SIZEOF_CHAR 1
| #define SIZEOF_SHORT 2
| #define SIZEOF_LONG 8
| #define SIZEOF_LONG_LONG 8
| #define SIZEOF_OFF_T 8
| #define SIZEOF_SIZE_T 8
| #define SIZEOF_SSIZE_T 8
| #define HAVE_INTPTR_T 1
| #define HAVE_UINTPTR_T 1
| #define HAVE_PTRDIFF_T 1
| #define HAVE_IMMEDIATE_STRUCTURES 1
| /* end confdefs.h.  */
| 
|                                 #undef HAVE_UINTPTR_T
| 				/* we have our own configure tests */
| 				#include <Python.h>
| 
| int
| main ()
| {
| 
| 				Py_InitModule(NULL, NULL);
| 
|   ;
|   return 0;
| }
configure:7599: /usr/bin/clang -o conftest -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -arch x86_64  -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -L/opt/local/lib -Wl,-headerpad_max_install_names -lintl -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -arch x86_64 conftest.c   >&5
conftest.c:45:14: fatal error: 'Python.h' file not found
                                #include <Python.h>
                                         ^~~~~~~~~~
1 error generated.
configure:7599: $? = 1
configure: failed program was:
| /* confdefs.h */
| #define PACKAGE_NAME "Samba"
| #define PACKAGE_TARNAME "samba"
| #define PACKAGE_VERSION "3"
| #define PACKAGE_STRING "Samba 3"
| #define PACKAGE_BUGREPORT "samba-technical@samba.org"
| #define PACKAGE_URL ""
| #define CONFIG_H_IS_FROM_SAMBA 1
| #define STDC_HEADERS 1
| #define HAVE_SYS_TYPES_H 1
| #define HAVE_SYS_STAT_H 1
| #define HAVE_STDLIB_H 1
| #define HAVE_STRING_H 1
| #define HAVE_MEMORY_H 1
| #define HAVE_STRINGS_H 1
| #define HAVE_INTTYPES_H 1
| #define HAVE_STDINT_H 1
| #define HAVE_UNISTD_H 1
| #define __EXTENSIONS__ 1
| #define _ALL_SOURCE 1
| #define _GNU_SOURCE 1
| #define _POSIX_PTHREAD_SEMANTICS 1
| #define _TANDEM_SOURCE 1
| #ifndef _XOPEN_SOURCE_EXTENDED
| #define _XOPEN_SOURCE_EXTENDED 1
| #endif
| #define HAVE_STANDARDS_H 1
| #define HAVE_LONG_LONG 1
| #define SIZEOF_INT 4
| #define SIZEOF_CHAR 1
| #define SIZEOF_SHORT 2
| #define SIZEOF_LONG 8
| #define SIZEOF_LONG_LONG 8
| #define SIZEOF_OFF_T 8
| #define SIZEOF_SIZE_T 8
| #define SIZEOF_SSIZE_T 8
| #define HAVE_INTPTR_T 1
| #define HAVE_UINTPTR_T 1
| #define HAVE_PTRDIFF_T 1
| #define HAVE_IMMEDIATE_STRUCTURES 1
| /* end confdefs.h.  */
| 
|                                 #undef HAVE_UINTPTR_T
| 				/* we have our own configure tests */
| 				#include <Python.h>
| 
| int
| main ()
| {
| 
| 				Py_InitModule(NULL, NULL);
| 
|   ;
|   return 0;
| }
configure:7621: checking working python module support
configure:7628: result: no

comment:7 Changed 4 years ago by eschnett (Erik Schnetter)

Cc: eschnett added

comment:8 Changed 4 years ago by juanalexei

Cc: juanalexei added

comment:9 Changed 4 years ago by wahspilihp (Philip Shaw)

Cc: wahspilihp added

comment:10 Changed 4 years ago by Guymer (Thomas Guymer)

Cc: Guymer added

comment:11 Changed 4 years ago by ShadSterling (Shad Sterling)

Cc: ShadSterling added

comment:12 Changed 4 years ago by olupton (Olli Lupton)

Cc: olupton added

comment:13 Changed 4 years ago by Guymer (Thomas Guymer)

Am I correct in assuming that the only reason why ffmpeg requires samba3 is to allow the user to do something like "ffmpeg ​smb://server:/file ..."? If so, given that Mac OSX is able to mount SMB shares natively, can we just drop SMB support from within ffmpeg itself and, therefore, remove the dependency upon samba3 -- thus sidestepping this ticket completely? In the end, all I want is a working installation of ffmpeg (with or without ​smb:// support).

comment:14 Changed 4 years ago by dliessi (Davide Liessi)

Cc: dliessi added

comment:15 Changed 4 years ago by captainproton1971 (Captain Proton)

Cc: captainproton1971 added

comment:16 Changed 4 years ago by Guymer (Thomas Guymer)

It appears that this is not going to be fixed soon, so as a temporary workaround, might it just be better to remove the single offending line from the ffmpeg Portfile: ​https://github.com/macports/macports-ports/blob/master/multimedia/ffmpeg/Portfile#L348 ? I do not require ffmpeg to be a smbclient, but I would like the --enable-version3 from the previous line.

comment:17 Changed 4 years ago by mf2k (Frank Schima)

Cc: azakru added

Has duplicate #62396.

comment:18 Changed 4 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Cc: MarcusCalhoun-Lopez added

comment:19 Changed 4 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Owner: set to MarcusCalhoun-Lopez
Resolution: → fixed
Status: new → closed

In 52f9c06c93a36294980fc2022159837410cb99a8/macports-ports (master):

samba3: fix build on recent Xcode versions

Fixes #61454

comment:20 Changed 3 years ago by mascguy (Christopher Nielsen)

Cc: mascguy added
Note: See TracTickets for help on using tickets.