lv @4.51: implicit declaration of function

[fu7mu4 (fu7mu4)]

"sudo port install lv" failed to build lv, because of lack of header-includes in bellow source files:

• strncmp in guess.c requires <string.h> and
• toupper in guesslocale.c requires <ctypes.h>

I could build lv after adding some header

--- guess.c.org	2020-11-17 06:05:38.000000000 +0900
+++ guess.c	2020-11-17 06:06:32.000000000 +0900
@@ -21,6 +21,7 @@
  */

 #include <stdio.h>
+#include <string.h>

 #include <import.h>
 #include <decode.h>

--- guesslocale.c.org	2020-11-17 06:06:49.000000000 +0900
+++ guesslocale.c	2020-11-17 06:07:19.000000000 +0900
@@ -19,6 +19,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
+#include <ctype.h>

 #ifdef HAVE_SETLOCALE

[fu7mu4 (fu7mu4)]

patch to guess.c

[fu7mu4 (fu7mu4)]

patch to guesslocale.c

[ryandesign (Ryan Carsten Schmidt)]

Thanks!

[ryandesign (Ryan Carsten Schmidt)]

These changes are not sufficient. There are also similar problems in the configure script's tests which need to be fixed so that the configure script does not produce wrong results. From conflg.log:

configure:1332:67: error: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Werror,-Wimplicit-function-declaration]
configure:1525:15: error: implicit declaration of function 'getpid' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
configure:1526:15: error: implicit declaration of function 'getpgrp' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
configure:1536:17: error: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Werror,-Wimplicit-function-declaration]
configure:1538:17: error: implicit declaration of function 'fork' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
configure:1548:17: error: implicit declaration of function 'setpgrp' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
configure:1556:17: error: implicit declaration of function 'wait' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

[ryandesign (Ryan Carsten Schmidt)]

In b2dda8abd93dad1740aa47fb159c303424852afc/macports-ports (master):

lv: Fix implicit declaration of functions

Closes: #61512