Opened 4 years ago

Closed 4 years ago

#61512 closed defect (fixed)

lv @4.51: implicit declaration of function

Reported by: fu7mu4 (fu7mu4) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.6.4
Keywords: haspatch catalina bigsur Cc:
Port: lv

Description

"sudo port install lv" failed to build lv, because of lack of header-includes in bellow source files:

  • strncmp in guess.c requires <string.h> and
  • toupper in guesslocale.c requires <ctypes.h>

I could build lv after adding some header

--- guess.c.org	2020-11-17 06:05:38.000000000 +0900
+++ guess.c	2020-11-17 06:06:32.000000000 +0900
@@ -21,6 +21,7 @@
  */

 #include <stdio.h>
+#include <string.h>

 #include <import.h>
 #include <decode.h>
--- guesslocale.c.org	2020-11-17 06:06:49.000000000 +0900
+++ guesslocale.c	2020-11-17 06:07:19.000000000 +0900
@@ -19,6 +19,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
+#include <ctype.h>

 #ifdef HAVE_SETLOCALE

Attachments (2)

guess.c.missing-header.diff (210 bytes) - added by fu7mu4 (fu7mu4) 4 years ago.
patch to guess.c
guesslocale.c.missing-header.diff (324 bytes) - added by fu7mu4 (fu7mu4) 4 years ago.
patch to guesslocale.c

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by fu7mu4 (fu7mu4)

Attachment: guess.c.missing-header.diff added

patch to guess.c

Changed 4 years ago by fu7mu4 (fu7mu4)

patch to guesslocale.c

comment:1 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch catalina bigsur added
Summary: lv 451 failed to build on macOS BigSurlv @4.51: implicit declaration of function

Thanks!

comment:2 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

These changes are not sufficient. There are also similar problems in the configure script's tests which need to be fixed so that the configure script does not produce wrong results. From conflg.log:

configure:1332:67: error: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Werror,-Wimplicit-function-declaration]
configure:1525:15: error: implicit declaration of function 'getpid' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
configure:1526:15: error: implicit declaration of function 'getpgrp' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
configure:1536:17: error: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Werror,-Wimplicit-function-declaration]
configure:1538:17: error: implicit declaration of function 'fork' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
configure:1548:17: error: implicit declaration of function 'setpgrp' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
configure:1556:17: error: implicit declaration of function 'wait' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

comment:3 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: set to ryandesign
Resolution: fixed
Status: newclosed

In b2dda8abd93dad1740aa47fb159c303424852afc/macports-ports (master):

lv: Fix implicit declaration of functions

Closes: #61512

Note: See TracTickets for help on using tickets.