blackbox @0.76 does not build on PPC Tiger, Mac OS X 10.4.11,

[ballapete (Peter "Pete" Dyballa)]

/bin/sh ../libtool  --tag=CXX   --mode=compile /opt/local/bin/g++-mp-7 -DHAVE_CONFIG_H -I. -I..  -include config.h -I..    -I/opt/local/include -I/opt/local/include/LegacySupport  -pipe -Os -Wno-format-security -std=c++98 -fpermissive -arch ppc -c -o EWMH.lo EWMH.cc
libtool: compile:  /opt/local/bin/g++-mp-7 -DHAVE_CONFIG_H -I. -I.. -include config.h -I.. -I/opt/local/include -I/opt/local/include/LegacySupport -pipe -Os -Wno-format-security -std=c++98 -fpermissive -arch ppc -c EWMH.cc  -fno-common -DPIC -o .libs/EWMH.o
EWMH.cc: In member function 'void bt::EWMH::setStartupId(Window, Window) const':
EWMH.cc:799:14: error: 'getenv' was not declared in this scope
   if (!(id = getenv("DESKTOP_STARTUP_ID")))
              ^~~~~~
EWMH.cc:799:14: note: suggested alternative: 'getwc'
   if (!(id = getenv("DESKTOP_STARTUP_ID")))
              ^~~~~~
              getwc
EWMH.cc:805:3: error: 'unsetenv' was not declared in this scope
   unsetenv("DESKTOP_STARTUP_ID");
   ^~~~~~~~
EWMH.cc:805:3: note: suggested alternative: 'ungetwc'
   unsetenv("DESKTOP_STARTUP_ID");
   ^~~~~~~~
   ungetwc
make[2]: *** [EWMH.lo] Error 1
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_x11_blackbox/blackbox/work/blackbox-0.76/lib'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_x11_blackbox/blackbox/work/blackbox-0.76'
make: *** [all] Error 2
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_x11_blackbox/blackbox/work/blackbox-0.76'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_x11_blackbox/blackbox/work/blackbox-0.76" && /usr/bin/make -w all 
Exit code: 2

Is a new legacy support missing? It has (only):

      5 PortGroup               legacysupport 1.0

[ballapete (Peter "Pete" Dyballa)]

Main.log from PPC Tiger, Mac OS X 10.4.11

[kencu (Ken)]

I'm not sure just why it is now needed, but explicitly adding #include <stdlib.h> to EWMH.cc after the other includes fixes the build.

[ballapete (Peter "Pete" Dyballa)]

Replying to kencu:

This worked for me too. Patch added!

[ballapete (Peter "Pete" Dyballa)]

Patch to add the missing C header file

[ballapete (Peter "Pete" Dyballa)]

Same failure and same cure on PPC Leopard, Mac OS X 10.5.8.

[kencu (Ken)]

In 8855e386d49f2752c5a2e5709821c26ebd6012fe/macports-ports (master):

blackbox: fix missing header on old systems

closes: #61561