Opened 4 years ago

Closed 4 years ago

#61706 closed defect (fixed)

cmake @3.19.1_0: patch-qt4gui.diff fails to apply

Reported by: hadrabap (Petr Hadraba) Owned by: michaelld (Michael Dickens)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: hadrabap (Petr Hadraba), adfernandes (Andrew Fernandes), dershow, barrettsa
Port: cmake

Description

localhost:~ petr$ sudo port install cmake +docs+gui+python36+qt4                                                                                        
--->  Computing dependencies for cmake
--->  Fetching archive for cmake
--->  Attempting to fetch cmake-3.19.1_0+docs+gui+python36+qt4.darwin_19.x86_64.tbz2 from https://nue.de.packages.macports.org/cmake
--->  Attempting to fetch cmake-3.19.1_0+docs+gui+python36+qt4.darwin_19.x86_64.tbz2 from https://packages.macports.org/cmake
--->  Attempting to fetch cmake-3.19.1_0+docs+gui+python36+qt4.darwin_19.x86_64.tbz2 from https://lil.fr.packages.macports.org/cmake
--->  Fetching distfiles for cmake
--->  Verifying checksums for cmake
--->  Extracting cmake
--->  Applying patches to cmake
Error: Failed to patch cmake: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_cmake/cmake/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.
Error: Processing of port cmake failed

Attachments (1)

main.log (143.7 KB) - added by hadrabap (Petr Hadraba) 4 years ago.
main.log

Download all attachments as: .zip

Change History (16)

Changed 4 years ago by hadrabap (Petr Hadraba)

Attachment: main.log added

main.log

comment:1 Changed 4 years ago by hadrabap (Petr Hadraba)

Cc: hadrabap added

comment:2 Changed 4 years ago by jmroot (Joshua Root)

Cc: michaelld removed
Owner: changed from michaelld@… to michaelld
Summary: cmake 1.19.1_0 fails to configurecmake @1.19.1_0: patch-qt4gui.diff fails to apply

comment:3 Changed 4 years ago by hadrabap (Petr Hadraba)

I've also tried the variant with Qt5 which fails to configure as well.

comment:4 Changed 4 years ago by jmroot (Joshua Root)

Cc: adfernandes added

comment:5 Changed 4 years ago by kencu (Ken)

you could just uninstall cmake, then install the vanilla version until the one with the variants you want is sorted out.

this is an issue with non-default variants; they are less tested (and you always have to build them).

comment:6 Changed 4 years ago by michaelld (Michael Dickens)

Summary: cmake @1.19.1_0: patch-qt4gui.diff fails to applycmake @3.19.1_0: patch-qt4gui.diff fails to apply

Well drat ... Looks like Qt4 support was removed for CMake 3.19 : https://gitlab.kitware.com/cmake/cmake/-/commit/e4d601546044be33f6eee549373ea093aa240d43

We can either do: (1) just drop Qt4 support entirely from CMake. (2) if +qt4 then revert CMake back to the final 3.18 release. Any preferences out there?

comment:7 Changed 4 years ago by michaelld (Michael Dickens)

One could in theory revert that commit, but that will be a pain to maintain -- both the Qt selection CMakeLists.txt file as well as any Qt code -- & so I'd prefer to not go that route. If somebody else wants to maintain the Qt4 variant of CMake then please step forward & claim your prize!

comment:8 Changed 4 years ago by dershow

Cc: dershow added

comment:9 in reply to:  6 Changed 4 years ago by jmroot (Joshua Root)

Replying to michaelld:

We can either do: (1) just drop Qt4 support entirely from CMake. (2) if +qt4 then revert CMake back to the final 3.18 release. Any preferences out there?

Changing the version number in a variant is highly problematic. I would suggest dropping the variant from the main cmake port and adding separate port or subport for 3.18 if there is demand.

comment:10 Changed 4 years ago by kencu (Ken)

Archivist as I am, I still don't feel a need for the qt4 cmake gui...I've installed it a few times, played around with it, but never saw much use for it for anything much.

We can resurrect 3.18 as some other port if there is a need from someone I guess.

comment:11 Changed 4 years ago by barrettsa

Cc: barrettsa added

comment:12 Changed 4 years ago by michaelld (Michael Dickens)

OK I'm just going to remove the +qt4 variant then. I agree with @kencu here: I've tried the Qt variants here and there, but I don't find them more useful than what non-gui cmake provides ... and, for remote debugging where a GUI isn't possible -- which is with customers as well as some of my in-network build systems -- knowing how to do text-based debugging is the way to go.

comment:13 Changed 4 years ago by michaelld (Michael Dickens)

I'll fix up the Qt5 patch along the way here.

comment:14 Changed 4 years ago by michaelld (Michael Dickens)

comment:15 Changed 4 years ago by michaelld (Michael Dickens)

Resolution: fixed
Status: assignedclosed

In db5a4e58cf534e2d199a826cb767f026b7a174f4/macports-ports (master):

cmake: fix Qt GUI to be great again!

Closes: #61706
Closes: #61726

Note: See TracTickets for help on using tickets.