Opened 4 years ago
Closed 4 years ago
#61712 closed defect (fixed)
mpstats should use OS version "11" for Big Sur (not 11.0, 11.1, etc.)
Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | neverpanic (Clemens Lang) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | ||
Port: | mpstats |
Change History (4)
comment:1 Changed 4 years ago by neverpanic (Clemens Lang)
comment:2 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)
Josh didn't want to change macosx_version
because that would be a backward-incompatible change. Instead he introduced macos_version
and macos_version_major
, the latter of which is what we want here, but they are not yet in a released version. See [1916d6f553cde96dd98c720e3b78a8f9bf29ca85/macports-base].
Until that's released, the mpstats client could use maybe:
# TODO: Just use $macos_version_major after MacPorts 2.7.0 is released if {[vercmp $macosx_version 11] >= 0} { dict set os osx_version [lindex [split $macosx_version .] 0] } else { dict set os osx_version [join [lrange [split $macosx_version .] 0 1] .] }
comment:3 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)
Actually I see he did change macosx_version
to match macos_version_major
, but again that change isn't released yet.
comment:4 Changed 4 years ago by neverpanic (Clemens Lang)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
That issue is client-side, not server-side. See https://github.com/macports/macports-ports/blob/master/sysutils/mpstats/files/mpstats.tcl#L387, where mpstats.tcl submits
${macports::macosx_version}
.If we want to change that, it needs to happen either in mpstats.tcl, or in base to change
macosx_version
.I don't have cycles to spare on this right now, so if any of the people who recently contributed to the mpstats client want to take a shot at this that'd be very welcome.