emacs-devel @20201127_2 has one configure option too much: --with-gmp

[ballapete (Peter "Pete" Dyballa)]

Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_editors_emacs/emacs-app-devel/work/emacs-20201127" && ./configure --prefix=/opt/local --disable-silent-rules --without-dbus --without-gconf --without-libotf --without-m17n-flt --with-gmp --with-gnutls --with-json --with-xml2 --with-modules --enable-locallisppath=/Library/Application\ Support/Emacs/calendar28:/Library/Application\ Support/Emacs --infodir /opt/local/share/info/emacs --with-ns --with-lcms2 --without-harfbuzz --without-imagemagick --without-xaw3d --with-rsvg 
DEBUG: system:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_editors_emacs/emacs-app-devel/work/emacs-20201127" && ./configure --prefix=/opt/local --disable-silent-rules --without-dbus --without-gconf --without-libotf --without-m17n-flt --with-gmp --with-gnutls --with-json --with-xml2 --with-modules --enable-locallisppath=/Library/Application\ Support/Emacs/calendar28:/Library/Application\ Support/Emacs --infodir /opt/local/share/info/emacs --with-ns --with-lcms2 --without-harfbuzz --without-imagemagick --without-xaw3d --with-rsvg 
configure: WARNING: unrecognized options: --with-gmp
checking for xcrun... xcrun

The same complaint comes from emacs-app-devel (which does not seem to build on macOS High Sierra, Version 10.13.6…).

GNU Emacs uses here a Germanised calendar and some other customisations.

[ballapete (Peter "Pete" Dyballa)]

It's just an unclean situation around installation:

DEBUG: Executing org.macports.destroot (emacs-app-devel)
DEBUG: system -W /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_editors_emacs/emacs-app-devel/work/emacs-20201127: make install
chdir: /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_editors_emacs/emacs-app-devel/work/emacs-20201127: No such file or directory
Command failed: make install
Exit code: 1
Error: Failed to destroot emacs-app-devel: command execution failed
DEBUG: Error code: NONE

[drkp (Dan Ports)]

In fb7bb03edf2871cfcd946f603d35e4fa066fcb8d/macports-ports (master):

emacs(-devel): remove unused configure option

Closes: #61742

[wyuenho (Jimmy Yuen Ho Wong)]

I don't understand the change here. The problem the author had seems to come from the working directory having some old build, possible emacs 26, there's no need to remove --with-gmp unless we want to use the included mini-gmp all the time, in which case we should delete port:gmp too. If --with-gmp is wrong, just replace it with --with-libgmp. If the problem is configure can't find gmp.h, maybe the fix is upstream or use a path dependency in depends_build?