Opened 4 years ago

Closed 3 years ago

#61768 closed defect (fixed)

buildbot/mpbb can upload a nondistributable archive to the public server

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: admin@…
Priority: Normal Milestone:
Component: buildbot/mpbb Version:
Keywords: Cc:
Port:

Description

Today I merged a PR which removed +openldap as a default variant of gnupg2 thus making it distributable.

The buildbot worker machines already had the port installed with the +openldap variant. This commit caused them to install it again without that variant. Because the version and revision did not change (there was no reason why the revision should have changed), buildbot kept both of these installed.

It then uploaded all installed archives for gnupg2 -- both with and without +openldap variant -- to the public server, since the port is distributable. It is not smart enough to realize that not all variants of the port necessarily have the same distributability.

I manually removed the archives for gnupg2 +openldap from the packages server but they'll keep getting reuploaded until I also uninstall them from each worker machine.

Change History (1)

comment:1 Changed 3 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed

In bf3bfbfa2a047340ace57ba03cb7a087fe8d8ce4/mpbb (master):

mpbb-gather-archives: granular license checking

Check distributability separately for each installed version (i.e.
variant combination) of the port.

Fixes: #61768

Note: See TracTickets for help on using tickets.