certbot and subports set dependencies incorrectly with most variants

[jmroot (Joshua Root)]

Dependencies are being set before the variants are executed, which means python.version has a fixed value. E.g.

% port deps certbot +python38
Full Name: certbot @1.10.1_0+python38
Build Dependencies:   py39-setuptools
Library Dependencies: py39-acme, py39-configargparse, py39-configobj,
                      py39-cryptography, py39-distro, py39-future,
                      py39-google-api, py39-httplib2, py39-mock,
                      py39-oauth2client, py39-openssl, py39-parsedatetime,
                      py39-psutil, py39-pyrfc3339, py39-six, py39-tz,
                      py39-zope-component, py39-zope-deferredimport,
                      py39-zope-deprecation, py39-zope-hookable, python38

[Schamschula (Marius Schamschula)]

The opposite is true: The variant block precedes the dependency block.

Maybe, it isn't parsed that way? Or perhaps, there is something else going on?

However, I can reproduce the issue. Indeed, I see it in other Portfiles.

[Schamschula (Marius Schamschula)]

PS: if the variants are not parsed before the dependents, no ${python.version} would have been set.

[jmroot (Joshua Root)]

Variant bodies are executed after the portfile is executed. You need to either set the dependencies inside the variants as well, or use variant_isset to set python.default_version before setting the dependencies.

[jmroot (Joshua Root)]

Replying to Schamschula:

PS: if the variants are not parsed before the dependents, no ${python.version} would have been set.

Correct, it is not set yet by the portfile, so it has its default value.

[jmroot (Joshua Root)]

I can fix this for you as an example of how to do it, if you like.

[Schamschula (Marius Schamschula)]

Please! There is obviously something I'm missing here.

I, and others, have used this code in a number of Python app Portfiles for quite a while w/o any apparent issues.

[jmroot (Joshua Root)]

You wouldn't have seen any issues as long as the variant selected matched the default python version.

[Schamschula (Marius Schamschula)]

Indeed! Until 3.9 came out recently, I was always building against the default version.

Setting the dependencies inside the variants is very clumsy: lots of redundant code. There must be a more elegant way to do this.

This makes Python app ports a pain as compared to Python libraries.

[jmroot (Joshua Root)]

In 9599959c17dac22e57ae56b4d177e9d0a357f430/macports-ports (master):

certbot: fix dependencies

The python.default_version option has to be set before using
${python.version} in the depspecs. Variant bodies are executed after
the rest of the Portfile has been parsed, so setting it there is too
late.

Fixes: #61810

[Schamschula (Marius Schamschula)]

Thanks, Joshua!

Time to use this elsewhere.

[Schamschula (Marius Schamschula)]

In 8af2fcd54732516aac6106f79359dba267f5b090/macports-ports (master):

xonsh: fix dependency issue.

See: #61810

[Schamschula (Marius Schamschula)]

In f6b12c7f975556c8b39a8d4c3ac1dbb94837f1cf/macports-ports (master):

holoviews: fix dependency issue

See: #61810

[Schamschula (Marius Schamschula)]

In c79a9c0bca6d769e99d8f443a166abf94c021d21/macports-ports (master):

img2pdf: fix dependency issue

See: #61810