codec2: error: unknown argument: '-no-pie'

[chrstphrchvz (Christopher Chavez)]

codec2 ​currently fails to build on macOS 10.8-10.12 because Xcode clang previously did not recognize the -no-pie option (although those versions likely support using -nopie instead):

[ 38%] Building C object unittest/CMakeFiles/ofdm_stack.dir/ofdm_stack.c.o
cd /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_audio_codec2/codec2/work/build/unittest && /usr/bin/clang -DFLOATING_POINT -DGIT_HASH=\"None\" -DMODEMPROBE_ENABLE -DVAR_ARRAYS -DXXXXX -D__UNITTEST__ -I/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_audio_codec2/codec2/work/build -I/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_audio_codec2/codec2/work/codec2-c3c49614467dbab9f155394015f7f30e7ffdfc2f/unittest/../src -pipe -Os -DNDEBUG -I/opt/local/include -Wall -Wno-strict-overflow -std=gnu11 -fPIC -arch x86_64 -mmacosx-version-min=10.12 -finstrument-functions -no-pie -o CMakeFiles/ofdm_stack.dir/ofdm_stack.c.o -c /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_audio_codec2/codec2/work/codec2-c3c49614467dbab9f155394015f7f30e7ffdfc2f/unittest/ofdm_stack.c
clang: error: unknown argument: '-no-pie'

-no-pie is hardcoded in ​unittest/CMakeLists.txt.

One workaround would be to use MacPorts' clang (as done on 10.7 and earlier). But is there a way (which upstream might incorporate) to use -nopie instead of -no-pie when appropriate?

(I personally do not use this port.)

[chrstphrchvz (Christopher Chavez)]

After looking more carefully, I found this issue was ​reported upstream at least twice, but closed unaddressed. Maybe they aren't interested in supporting old compilers.

[ra1nb0w]

Thank you very much for the report. Now, I try to contact the developers and will try to implement the check on cmake since I don't like too much to install requirements when not needed.

[Davide Gerhard <ra1nb0w@…>]

In 3cf2d0b73beb4319b10bad1c14b629a75d40ee78/macports-ports (master):

codec2: build code as release

this avoid:

• debug flags
• unittest build

Closes: #62044

[ra1nb0w]

Now should work fine. Can you test?

[chrstphrchvz (Christopher Chavez)]

I do not have access to an affected macOS version. It appears that the builds triggered from your commit have already finished, so I think things are fine now.