Opened 4 years ago

Last modified 21 months ago

#62071 new defect

Tests fail if no portfiles are modified

Reported by: harens (Haren S) Owned by: admin@…
Priority: Normal Milestone:
Component: server/hosting Version:
Keywords: Cc: l2dy (Zero King)
Port:

Description

If no ports are changed, this currently causes both the Azure Pipelines and GitHub Actions to fail. This is an issue if files that aren't ports are modified, such as those in the _resources or .github folder. This also brings into question the test coverage of files that aren't ports.

The tests fail during the Determine list of changed ports section, and give the following error:

/Users/runner/work/_temp/143ecc73-c99f-487c-b507-286338e5b5c9.sh: line 16: portlist[@]: unbound variable

All other stages are skipped, until the Make logfiles readable section, where it fails again.

find: /tmp/mpbb: No such file or directory

A temporary workaround is to also modify a Portfile in the PR, but leave it as a separate commit if necessary since it affects a different file.

Attachments (1)

1_macos-10.15.txt (64.5 KB) - added by harens (Haren S) 4 years ago.
The log file for GitHub Actions on a PR with no modified portfiles

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by harens (Haren S)

Attachment: 1_macos-10.15.txt added

The log file for GitHub Actions on a PR with no modified portfiles

comment:1 Changed 3 years ago by l2dy (Zero King)

Cc: l2dy added

comment:2 in reply to:  description Changed 21 months ago by ryandesign (Ryan Carsten Schmidt)

Replying to harens:

/Users/runner/work/_temp/143ecc73-c99f-487c-b507-286338e5b5c9.sh: line 16: portlist[@]: unbound variable

https://github.com/macports/macports-ports/pull/17774 should address this.

find: /tmp/mpbb: No such file or directory

This is not yet addressed.

comment:3 Changed 21 months ago by ryandesign (Ryan Carsten Schmidt)

In 99d77366d2598857e1545d61a3bbd224677704d4/macports-ports (master):

ci: Make portlist a string not an array

There does not seem to be any need to treat portlist as an array in this
step since we only ever get the entire array here, and in subsequent
steps we already treat it as string. Getting the entire array fails if
there are no elements (i.e. if the commit only modified files that are
not port files).

See: #62071

Note: See TracTickets for help on using tickets.