Opened 4 years ago
Closed 13 months ago
#62339 closed defect (fixed)
MacVim wants to update through its built-in update mechanism
| Reported by: | szhorvat (Szabolcs Horvát) | Owned by: | raimue (Rainer Müller) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.6.4 |
| Keywords: | Cc: | cooljeanius (Eric Gallager) | |
| Port: | MacVim |
Description
When I start MacVim, it wants to auto-update (see attached screenshot). Since software that is part of MacPorts is updated/managed by MacPorts, should their built-in update mechanisms not be disabled?
Attachments (1)
Change History (8)
Changed 4 years ago by szhorvat (Szabolcs Horvát)
| Attachment: | Screenshot 2021-02-21 at 11.09.21.png added |
|---|
comment:1 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | raimue removed |
|---|---|
| Owner: | set to raimue |
| Status: | new → assigned |
comment:2 Changed 4 years ago by szhorvat (Szabolcs Horvát)
comment:3 Changed 4 years ago by raimue (Rainer Müller)
Thanks for confirming it is still a problem. Sparkle is supposed to be disabled, but apparently the option in the build system is not working as intended. I will have to check this again.
comment:4 Changed 4 years ago by cooljeanius (Eric Gallager)
| Cc: | cooljeanius added |
|---|
comment:6 Changed 2 years ago by raimue (Rainer Müller)
Analyzing the history, I think the problem was introduced with 6418dc0d7fa5fa66993a2959a3704cd0196c4b38 as since then Sparkle.framework is no longer removed from the Xcode project.
Upstream also has a `--disable-sparkle` configure argument that we use and it is supposed to set the XCODEFLAGS to disable Sparkle.
However, the Portfile sets its own values for XCODEFLAGS and I would assume that the GCC_PREPROCESSOR_DEFINITIONS='$GCC_PREPROCESSOR_DEFINITIONS DISABLE_SPARKLE=1' is lost due to this.
One possible solution could be to include this GCC_PREPROCESSOR_DEFINITIONS in our XCODEFLAGS in the Portfile.
comment:7 Changed 13 months ago by raimue (Rainer Müller)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
The current MacVim port patches the Info.plist to remove the updater channel. This should fix the issue.
MacVim is still prompting to do updates. If I let it update by itself, next time MacPorts won't be able to update it properly.