Opened 4 years ago

Closed 4 years ago

#62549 closed defect (fixed)

py35-spyder fails to build

Reported by: jmroot (Joshua Root) Owned by: reneeotten (Renee Otten)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: py-spyder

Change History (5)

comment:1 Changed 4 years ago by reneeotten (Renee Otten)

The py35-spyder version is set in the Portfile to 4.1.6 and that one will build with Python 3.5 for sure. However, the distfile it downloads https://distfiles.macports.org/py-spyder/spyder-4.1.6.tar.gz actually contains version 4.2.1....

I don't know how that happened since I think I did the update, and restricting it to 4.1.6 correctly in this commit. I think that file should just be removed/ignored and all should be good again - would increasing the revision do that trick?

comment:2 Changed 4 years ago by jmroot (Joshua Root)

port distfiles py35-spyder shows the problem.

https://github.com/spyder-ide/spyder/archive/v4.2.4/spyder-4.1.6.tar.gz

Not sure if github.setup isn't designed to be called multiple times, or what.

comment:3 Changed 4 years ago by reneeotten (Renee Otten)

it could be the github.tarball_from archive that is the problem here. I think that should be added after the next github.setup as well. I'll push a commit that hopefully fixes this.

comment:4 Changed 4 years ago by jmroot (Joshua Root)

Yeah, it looks like setting github.tarball_from sets master_sites. So if you do that before git.branch has its final value, it will be incorrect.

No need for a rev bump when fixing this BTW, since it has never been able to build, and the mirror job will notice that the checksum doesn't match and re-download.

comment:5 Changed 4 years ago by reneeotten (Renee Otten)

Resolution: fixed
Status: assignedclosed

In 72ab7f92fd237d304994de80f4078adeaa738468/macports-ports (master):

py-spyder: fix distfile issue

Closes: #62549

Note: See TracTickets for help on using tickets.