OpenCOLLADA build failure on macOS 11

[gallafent]

Seemingly relevant fragment of build log:

:info:build /Volumes/S860E1TB/opt/local/var/macports/build/_Volumes_S860E1TB_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_
graphics_opencollada/opencollada/work/OpenCOLLADA-1.6.68/DAEValidator/library/src/Dae.cpp:307:23: error: loop variable 'node' is always a copy because
 the range of type 'const opencollada::XmlNodeSet' does not return a reference [-Werror,-Wrange-loop-analysis]
:info:build                                 for (const auto & node : nodes)
:info:build                                                   ^
:info:build /Volumes/S860E1TB/opt/local/var/macports/build/_Volumes_S860E1TB_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_
graphics_opencollada/opencollada/work/OpenCOLLADA-1.6.68/DAEValidator/library/src/Dae.cpp:307:10: note: use non-reference type 'opencollada::XmlNode'
:info:build                                 for (const auto & node : nodes)
:info:build                                      ^~~~~~~~~~~~~~~~~~~

[gallafent]

OpenCOLLADA build log on macOS 11

[jasonliu-- (Jason Liu)]

The newest version of OpenCOLLADA, version 1.6.68, was ​released on 2018 Nov 26, and there's no evidence that the Khronos Group has made any efforts to update their source code to be compatible with macOS 11. Do you have reason to believe that it is supposed to be compatible with macOS 11?

[jasonliu-- (Jason Liu)]

I just found some patches that the Blender devs implemented to allow OpenCOLLADA to compile on arm64. Based on the submitted build log, it looks like the same errors are occurring on macOS 11 x86_64.

​https://github.com/blender/blender/commit/9715ad5acad9a42b65efd64b6c7fbe157f949bfb

(specifically, the section that makes additions to build_files/build_environment/patches/opencollada.diff)

[jasonliu-- (Jason Liu)]

Submitted PR ​https://github.com/macports/macports-ports/pull/10694

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

In 418101f903921491554a3844c647a886fe3f4092/macports-ports (master):

opencollada: avoid -Werror

Fixes #62706
Closes ​https://github.com/macports/macports-ports/pull/10694