Opened 4 years ago

Closed 23 months ago

Last modified 13 months ago

#62833 closed defect (fixed)

libmsn @4.1_2 +debug: error: unknown type name 'des_key_schedule'; did you mean 'DES_key_schedule'?

Reported by: cooljeanius (Eric Gallager) Owned by: kencu (Ken)
Priority: Normal Milestone:
Component: ports Version: 2.6.4
Keywords: Cc:
Port: libmsn

Description

Presumably an openssl update broke compatibility or something:

[ 86%] Building CXX object msn/CMakeFiles/msn.dir/libsiren/rmlt.cpp.o
cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1/msn && /usr/bin/clang++ -Dmsn_EXPORTS -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1 -I/opt/local/include -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1/msn -pipe -Os -stdlib=libc++ -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk -g -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk -mmacosx-version-min=11.3 -fPIC -o CMakeFiles/msn.dir/libsiren/rmlt.cpp.o -c /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1/msn/libsiren/rmlt.cpp
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1/msn/util.cpp:264:9: error: unknown type name 'des_key_schedule'; did you mean 'DES_key_schedule'?
        des_key_schedule ks1,ks2,ks3;
        ^~~~~~~~~~~~~~~~
        DES_key_schedule
/opt/local/include/openssl/des.h:43:3: note: 'DES_key_schedule' declared here
} DES_key_schedule;
  ^
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1/msn/util.cpp:270:22: error: use of undeclared identifier 'C_Block'
        des_set_key((C_Block *)one,ks1);
                     ^
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1/msn/util.cpp:270:31: error: expected expression
        des_set_key((C_Block *)one,ks1);
                              ^
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1/msn/util.cpp:271:22: error: use of undeclared identifier 'C_Block'
        des_set_key((C_Block *)two,ks2);
                     ^
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1/msn/util.cpp:271:31: error: expected expression
        des_set_key((C_Block *)two,ks2);
                              ^
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1/msn/util.cpp:272:22: error: use of undeclared identifier 'C_Block'
        des_set_key((C_Block *)three,ks3);
                     ^
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1/msn/util.cpp:272:31: error: expected expression
        des_set_key((C_Block *)three,ks3);
                              ^
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1/msn/util.cpp:283:112: error: use of undeclared identifier 'C_Block'
        DES_ede3_cbc_encrypt((const unsigned char*)buf_.str().c_str(),output,buf_.str().size(),&ks1,&ks2,&ks3,(C_Block *)workvec,DES_ENCRYPT);
                                                                                                               ^
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1/msn/util.cpp:283:121: error: expected expression
        DES_ede3_cbc_encrypt((const unsigned char*)buf_.str().c_str(),output,buf_.str().size(),&ks1,&ks2,&ks3,(C_Block *)workvec,DES_ENCRYPT);
                                                                                                                        ^
9 errors generated.
make[2]: *** [msn/CMakeFiles/msn.dir/util.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1/msn/p2p.cpp:334:24: warning: 6 enumeration values not handled in switch: 'APP_NONE', 'APP_DISPLAY_PICTURE', 'APP_FILE_TRANSFER'... [-Wswitch]
                switch(session.typeTransfer)
                       ^
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1/msn/p2p.cpp:334:24: note: add missing switch cases
                switch(session.typeTransfer)
                       ^
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1/msn/soap.cpp:1748:62: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]
                       Member.getChildNode("Type").getText() == "Email")
                                                             ^  ~~~~~~~
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1/msn/notificationserver.cpp:1075:13: warning: expression result unused [-Wunused-value]
        for(d; d != listInfo->contactList.end(); d++)
            ^
1 warning generated.
1 warning generated.
1 warning generated.
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1'
make[1]: *** [msn/CMakeFiles/msn.dir/all] Error 2
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1'
make: *** [all] Error 2
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_libmsn/libmsn/work/libmsn-4.1" && /usr/bin/make -j16 -w all VERBOSE=ON 
Exit code: 2
Warning: The following existing files were hidden from the build system by trace mode:
  /Applications/MacPorts/CMake.app/Contents/MacOS/CMake
  /opt
  /private/var/select/sh

Attachments (1)

libmsnmain.log (70.3 KB) - added by cooljeanius (Eric Gallager) 4 years ago.
main.log for libmsn

Download all attachments as: .zip

Change History (10)

Changed 4 years ago by cooljeanius (Eric Gallager)

Attachment: libmsnmain.log added

main.log for libmsn

comment:1 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Probably not compatible with openssl ≥ 1.1 as noted here: https://sourceforge.net/p/libmsn/mailman/message/35159005/

We should update the port to the latest version 4.2.1 but that still predates openssl 1.1 by years so it won't fix this.

If we can fix it, maybe by finding a patch from debian or other distribution, great, otherwise we can make the port use openssl 1.0. There is a portgroup to assist with this.

comment:2 Changed 23 months ago by mpbb77 (Miguel Branco)

I've just tried to install the full kde4 package on Monterey and it stopped at this issue. So, what can I deduce from the fact that this ticket is 20 months old ? That nobody installs any more kde at all even for fun or that it is actually deprecated by this very transition to openssl 1.1 (maybe there is already a way to force the port to use 1.0 as noted above) ?

comment:3 Changed 23 months ago by mpbb77 (Miguel Branco)

ok, I guess that the lack of any feedback speaks for itself. I've searched for any hint like "kde port on macports deprecated" or the like but even that seems silentful. Then the kde package is listed as not ported since years so I should have known better.

comment:4 Changed 23 months ago by kencu (Ken)

Owner: set to kencu
Resolution: fixed
Status: newclosed

In 3f362e8cfd94e0918f74f800bdfeadbd614928be/macports-ports (master):

libmsn: update to 4.2.1

use openssl 1.0 (newer versions didn't build).
closes: #62833

comment:5 Changed 23 months ago by kencu (Ken)

I don't use this port, but it seemed like you were really hoping it would be fixed, so I took 5 minutes to update and fix it for you.

It looks like it is building successfully on most systems; I'll check back later to see if any of them failed and take care of that if so.

comment:6 Changed 23 months ago by cooljeanius (Eric Gallager)

Thanks for the fix! I can confirm that libmsn installs for me now. mpbb77, if you are trying to install the kde ports, the next bug you'll probably run into would be #62880, for reference.

comment:7 Changed 23 months ago by kencu (Ken)

OK, fixed a half-dozen more little issues like this, and all of the kde ports specified by:

sudo port -v -N install kde

now install without any trouble for me on Ventura at least, using all and only the default variants.

comment:8 Changed 23 months ago by kencu (Ken)

however, you may find a lack of happiness with these kde ports once they are installed, at least on newer systems:

% /Applications/MacPorts/KDE4/ark.app/Contents/MacOS/ark
2022-12-20 09:26:23.888 ark[94871:1644786] *** Assertion failure in -[NSNib initWithContentsOfURL:], NSNib.m:65
2022-12-20 09:26:23.890 ark[94871:1644786] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Deprecated in 10.8.'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007ff800e8acc3 __exceptionPreprocess + 242
	1   libobjc.A.dylib                     0x00007ff8009d910a objc_exception_throw + 48
	2   Foundation                          0x00007ff801c69fb0 -[NSCalendarDate initWithCoder:] + 0
	3   AppKit                              0x00007ff804535613 -[NSNib initWithContentsOfURL:] + 105
	4   QtGui                               0x0000000111ad23cf _Z18qt_mac_loadMenuNibP16QCocoaMenuLoader + 751
	5   QtGui                               0x0000000111ad5955 _Z7qt_initP19QApplicationPrivatei + 2117
	6   QtGui                               0x0000000111b42f48 _ZN19QApplicationPrivate9constructEv + 568
	7   QtGui                               0x0000000111b4333e _ZN12QApplicationC2ERiPPcbi + 94
	8   libkdeui.5.14.3.dylib               0x0000000110c64ce6 _ZN12KApplicationC2Eb + 62
	9   ark                                 0x000000010fb3e41d main + 5245
	10  dyld                                0x00007ff800a05310 start + 2432
)
libc++abi: terminating with uncaught exception of type NSException
zsh: abort      /Applications/MacPorts/KDE4/ark.app/Contents/MacOS/ark

I am not going to be digging in on this kind of issue for you. What may or may not be fixable in there is a good question.

comment:9 Changed 13 months ago by mpbb77 (Miguel Branco)

Thanks for the follow-up, seemingly I'd missed your replies / fixes / hints but as I've tried to compile kde again on Sonoma I've indeed ended up stumbling on your last-post's "Deprecated in 10.8" exception. KDE +all compiled fine though, except some minor tweakings (usual suspects akonadi, kiten, etc.). Actually I'm glad to know this issue was already around in Ventura and so is not related to Sonoma or latest Xcode.

Note: See TracTickets for help on using tickets.