webkit2-gtk @2.28.2_2 +debug+minibrowser+quartz: error: use of undeclared identifier 'remoteProcessID'

[cooljeanius (Eric Gallager)]

I fixed this before but forgot to save my patch, so I've regenerated it and am making sure to submit it this time. The error I'm fixing is this:

/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_www_webkit2-gtk/webkit2-gtk/work/webkitgtk-2.28.2/Source/WebKit/Platform/IPC/Connection.cpp:672:223: error: use of undeclared identifier 'remoteProcessID'
    RELEASE_LOG_ERROR(IPC, "Connection::waitForSyncReply: Timed-out while waiting for reply for %{public}s::%{public}s from process %d, id = %" PRIu64, messageReceiverName.toString().data(), messageName.toString().data(), remoteProcessID(), syncRequestID);
                                                                                                                                                                                                                              ^
1 error generated.

Will attach patch next.

[cooljeanius (Eric Gallager)]

patch I had to apply to webkit2-gtk sources to get it to build for me

[kencu (Ken)]

I haven't seen this issue so far. Looks like an undeclared function error? What system are you on?

FWIW, it looks like this is just a logging thing, but getpid returns the local id, and remoteProcessID was supposed to give the calling function's ID...

[kencu (Ken)]

here's the current source

​https://trac.webkit.org/browser/webkit/trunk/Source/WebKit/Platform/IPC/Connection.cpp#L699

[cooljeanius (Eric Gallager)]

Replying to kencu:

I haven't seen this issue so far. Looks like an undeclared function error? What system are you on?

I'm on Big Sur.

FWIW, it looks like this is just a logging thing, but getpid returns the local id, and remoteProcessID was supposed to give the calling function's ID...

I think it's ok to be wrong there if that's what it takes to get it to build; I'm not sure how to trigger that codepath anyways...

[albcn]

Same issue in here with macOS Monterey 12.3.1 on Apple M1 and 2.7.2 on arm64 builds. The proposed patch proposed by Eric works nicely (thanks).

[cooljeanius (Eric Gallager)]

Still occurs with webkit2-gtk @2.28.2_3

[kencu (Ken)]

this must only show up in the quartz build, on an M1 Mac.

here's where that function lives:

​https://github.com/WebKit/WebKit/search?q=remoteProcessID

Ideally someone (with a great deal of spare time :>) would upgrade this port to something a few years newer and see if that fixes it. For now, doing what Eric suggested gets it to build.

Or perhaps just delete that line of code for an M1 quartz build.

[cooljeanius (Eric Gallager)]

Replying to kencu:

this must only show up in the quartz build, on an M1 Mac.

I'm on x86_64 though; my MBP is from 2019

[kencu (Ken)]

oh, ok… quartz build on newer systems then, it seems.

[cooljeanius (Eric Gallager)]

Pull request opened: ​https://github.com/macports/macports-ports/pull/16898

[cooljeanius (Eric Gallager)]

In 3549bacfa635797227cb3c1161429d7d829a5115/macports-ports (master):

webkit2-gtk: fix quartz build on Big Sur

possibly closes: #62842 (untested)