heimdal @7.5.0_2: linking libheimbase.la fails with undefined symbols for architecture x86_64: _libintl_dgettext

[cooljeanius (Eric Gallager)]

I'm on macOS 11.4 with Xcode 12.5.1:

error.c:56:24: warning: self-comparison always evaluates to true [-Wtautological-compare]
    if (ap->error_code == ap->error_code)
                       ^
1 warning generated.
  CCLD     libheimbase.la
Undefined symbols for architecture x86_64:
  "_libintl_dgettext", referenced from:
      _stdb_open in bsearch.o
      _heim_db_create in db.o
      _db_replay_log in db.o
      _heim_db_clone in db.o
      _heim_db_commit in db.o
      _open_file in db.o
      _heim_db_set_value in db.o
      ...
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [libheimbase.la] Error 1
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_heimdal/heimdal/work/heimdal-7.5.0/lib/base'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_heimdal/heimdal/work/heimdal-7.5.0/lib'
make: *** [all-recursive] Error 1
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_heimdal/heimdal/work/heimdal-7.5.0'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_heimdal/heimdal/work/heimdal-7.5.0" && /usr/bin/make -j16 -w all 
Exit code: 2
Error: Failed to build heimdal: command execution failed
DEBUG: Error code: CHILDSTATUS 62697 2

libintl can be tricky to link with sometimes; I'd recommend checking heimdal's gettext dependency to make sure it's used properly.

[reneeotten (Renee Otten)]

most of the ports for which you opened tickets recently have no maintainer listed, which makes it less likely to get fixed anytime soon. On the other hand, you seem to be interested in the port (otherwise you wouldn't open a ticket) and have an idea of what could be wrong (here perhaps gettext) in many others due to implicit-function-declaration. Please consider trying to fix these things and submit a PR to have them include in the repository.

[cooljeanius (Eric Gallager)]

one step at a time; I want to finish filing the tickets I have in my backlog before I move on to trying to fix them myself...

[ryandesign (Ryan Carsten Schmidt)]

This specific issue might be the well-known macOS 11+ libtool bug. It wasn't clear from the log, since the build system used silent rules; I already fixed the port to disable silent rules.

heimdal also has a lot of implicit declaration of function problems, even in their latest code. I filed a bug report: ​https://github.com/heimdal/heimdal/issues/790

We should also update heimdal to the latest 7.7.0, though it is 2 years old.

[ryandesign (Ryan Carsten Schmidt)]

In 99bfa91032f138d3ead42b0f1ededc750df75496/macports-ports (master):

heimdal: Update to 7.7.0

Update to 7.7.0, fix libtool macOS 11+ bug, fix livecheck.

Closes: #63155