xfractint @20.04p14_0: build error: implicit declaration of function 'xpopup' is invalid in C99

[juliangilbey (Julian Gilbey)]

The compilation of this port failed with the following error message (in the log file):

:info:build /usr/bin/clang -I../headers -I./headers -DXFRACT -DWITH_XFT  -DNOBST
RING   -g -DBIG_ANSI_C -DLINUX -fno-builtin -I/opt/local/include/X11 -O2   -c -o
 encoder.o encoder.c
:info:build encoder.c:162:7: error: implicit declaration of function 'xpopup' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build       xpopup(cmd);
:info:build       ^
:info:build 1 error generated.

This is due to missing #include directives in both encoder.c and realdos.c. A patch is (or soon will be) attached that fixes this.

[juliangilbey (Julian Gilbey)]

Patch to include missing header files

[ryandesign (Ryan Carsten Schmidt)]

Thanks. Either you or the maintainer should also report this problem to the developer of xfractint so that they can fix it.

[juliangilbey (Julian Gilbey)]

Thanks Ryan!

Upstream have a new experimental version which does not seem to have this bug. (The development pace is glacial, incidentally.)

Best wishes, Julian

[Justin Flude <jflude@…>]

In c6e4af84c12e5c04aefa645215e63322b9e0896f/macports-ports (master):

xfractint: update to 20.04p16

Closes: #70092
Closes: #63280