Opened 3 years ago

Last modified 3 years ago

#63307 new defect

rsync-lart @2.6.6: error: array type 'va_list' (aka '__builtin_va_list') is not assignable

Reported by: cooljeanius (Eric Gallager) Owned by:
Priority: Normal Milestone:
Component: ports Version: 2.7.1
Keywords: Cc:
Port: rsync-lart

Description

There's a few errors when building it, but this is the first of them:

lib/snprintf.c:220:2: error: array type 'va_list' (aka '__builtin_va_list') is not assignable
        VA_COPY(args, args_in);
        ^~~~~~~~~~~~~~~~~~~~~~
lib/snprintf.c:155:35: note: expanded from macro 'VA_COPY'
#define VA_COPY(dest, src) (dest) = (src)
                           ~~~~~~ ^
1 error generated.
gnumake: *** [lib/snprintf.o] Error 1
gnumake: *** Waiting for unfinished jobs....

Note that there were some -Werror=implicit-function-declaration issues reported in config.log, so, since one of them was for snprintf, fixing that might mean it'd be possible to avoid even trying to build the buggy source file:

Warning: Configuration logfiles contain indications of -Wimplicit-function-declaration; check that features were not accidentally disabled:
  snprintf: found in rsync-2.6.6/config.log
  utime: found in rsync-2.6.6/config.log
  getgroups: found in rsync-2.6.6/config.log
  strcmp: found in rsync-2.6.6/config.log
  unlink: found in rsync-2.6.6/config.log
  _exit: found in rsync-2.6.6/config.log
  strcpy: found in rsync-2.6.6/config.log
  mkstemp: found in rsync-2.6.6/config.log
  vsnprintf: found in rsync-2.6.6/config.log
  exit: found in rsync-2.6.6/config.log
  fork: found in rsync-2.6.6/config.log

I'll attach the full logs next. Also ISTR rsync-lart conflicting with the main rsync port, too, last time I was able to get it to build, so it might be worth looking into that, too, once this is fixed.

Attachments (2)

rsync-lart_main.log (123.3 KB) - added by cooljeanius (Eric Gallager) 3 years ago.
main.log for rsync-lart
rsync-lart_config.log (207.2 KB) - added by cooljeanius (Eric Gallager) 3 years ago.
config.log for rsync-lart

Download all attachments as: .zip

Change History (4)

Changed 3 years ago by cooljeanius (Eric Gallager)

Attachment: rsync-lart_main.log added

main.log for rsync-lart

Changed 3 years ago by cooljeanius (Eric Gallager)

Attachment: rsync-lart_config.log added

config.log for rsync-lart

comment:1 Changed 3 years ago by ryandesign (Ryan Carsten Schmidt)

This port installs a Tiger-era version of rsync 2.6.6 with additional patches from Apple and patches from another developer to fix problems with Apple's implementation for copying extended attributes. Surely any necessary fixes for compatibility with Mac OS X 10.4 and later will have been integrated into the real rsync software by now, so I propose deleting this port. Anything still of relevance in this port should be reported to the developer of rsync for inclusion there.

comment:2 in reply to:  1 Changed 3 years ago by cooljeanius (Eric Gallager)

Replying to ryandesign:

This port installs a Tiger-era version of rsync 2.6.6 with additional patches from Apple and patches from another developer to fix problems with Apple's implementation for copying extended attributes. Surely any necessary fixes for compatibility with Mac OS X 10.4 and later will have been integrated into the real rsync software by now, so I propose deleting this port. Anything still of relevance in this port should be reported to the developer of rsync for inclusion there.

ok, sounds fair

Note: See TracTickets for help on using tickets.