Opened 3 years ago
Closed 3 years ago
#63349 closed update (fixed)
qemu: Update to version 6.0
Reported by: | IComplainInComments | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.7.1 |
Keywords: | Cc: | IComplainInComments, raimue (Rainer Müller) | |
Port: | qemu |
Description
qemu6 port for darwin (macOS 11) for AS/Intel
Attachments (1)
Change History (6)
Changed 3 years ago by IComplainInComments
comment:1 Changed 3 years ago by IComplainInComments
This is my first time submitting a portfile. If there are any errors, please let me know which errors so I may fix the problems. Thanks!
comment:2 follow-up: 3 Changed 3 years ago by jmroot (Joshua Root)
Cc: | raimue added |
---|---|
Summary: | Qemu6 → New port: Qemu6 |
Is there a reason not to update the qemu port to version 6?
comment:3 Changed 3 years ago by IComplainInComments
Replying to jmroot:
Is there a reason not to update the qemu port to version 6?
I guess that would be a better idea. Wouldnt I need permission from the Portfile owner though??
comment:4 Changed 3 years ago by raimue (Rainer Müller)
Keywords: | qemu qemu6 6.0 virtualization emulation development removed |
---|---|
Port: | qemu added; qemu6 removed |
Summary: | New port: Qemu6 → qemu: Update to version 6.0 |
comment:5 Changed 3 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | new → closed |
Type: | submission → update |
Yes. By submitting a ticket or pull request to update a port, you are requesting that permission. The maintainer can then respond or if they don't within 3 days, another committer can do so.
Your submission contained many errors:
- Your master_sites was wrong. (It needs to be the URL to the directory containing the file, not the URL to the file.)
- If you wanted to download and extract a tar.xz file, you needed to have added the line
use_xz yes
. - You listed many build dependencies in depends_lib. (They go in depends_build.)
- You didn't use
path:
dependency syntax for those ports that have alternatives (glib2, libpixman). - You used pkgconf instead of pkgconfig. pkgconf was recently added to MacPorts but so far only one port uses it (and it's unclear whether even that was necessary). Perhaps we need to modify all ports that use pkgconf or pkgconfig to use
path:
syntax to allow the user to choose which one they want. - You hardcoded /opt/local. You must use ${prefix} instead.
- You specified the prefix in configure.args. MacPorts already sets the prefix for you in configure.pre_args.
- You specified a configure argument for enabling libusb support but did not specify a dependency on the libusb port.
- Your description was not detailed enough.
- You didn't not specify the port's license.
- There was an unnecessary comment line at the top of the portfile.
- You didn't name the file "Portfile"
- You seem to have created this file from scratch rather than basing it on the existing qemu portfile. If we offer multiple portfiles for different versions of the same software, the portfiles should be as similar as possible and ideally maintained by the same person.
In the mean time, pull request 11932 was submitted to update the port to 6.0.0. It was closed in preference to pull request 11989 which updated the port to 6.1.0 and which has been merged.
Pull requests are the preferred way to submit new ports and port updates because it enables easier discussion about specific line changes and automatically performs trial builds.
port file I made for the port.