xdiskusage @1.54: extraneous boxes with a "?" appended to directory names

[q2go]

Hi there, I am new to MacPorts; I just installed 2.7.1 from scratch on Mojave 10.14.6 in order to install and use the xdiskusage 1.54 port.

So after installing the .pkg installation package provided on https://www.macports.org/install.php the first and only MacPort command I've ever run was "port install xdiskusage".

The /opt/local/bin/xdiskusage command does work, but for almost all directories it creates a second "phantom" box with question mark appended to the directory name.

This happens no matter whether I run "xdiskusage" (i.e. no arguments), "xdiskusage /some/path" or "df -k /some/path | xdiskusage -"; also adding a trailing slash to /some/path does not make a difference.

I wonder whether this is maybe caused by improper handling of line endings, as "echo -n '4711 local' | xdiskusage -" shows a box named "local" while the usual "echo '4711 local' | xdiskusage -" names it "local?".

Please see attached screenshots.

IMHO the purpose of "xdiskusage" — to provide a clean visual representation of file system usage — is quite significantly affected by this defect, so I set the priority to "normal" instead of "low".

[q2go]

Example #1: when run without arguments; directory path entered manually

[q2go]

Example #2: when run with arguments or fed through a pipe

[q2go]

Example #3: with "echo -n" and "echo"

[q2go]

I just noticed that the numbers are also way too high; /opt/local/var is not 3.6 GiB in size as suggested by the "var" box — in fact the value given in the "var?" box of 397.5 MiB is exactly correct:

$ du -ks /opt/local/var/
407072	/opt/local/var/
$ bc -l
bc 1.06
Copyright 1991-1994, 1997, 1998, 2000 Free Software Foundation, Inc.
This is free software with ABSOLUTELY NO WARRANTY.
For details type `warranty'. 
407072 / 1024
397.53125000000000000000

[ryandesign (Ryan Carsten Schmidt)]

Thank you for the detailed report and welcome to MacPorts. I had not noticed this problem before, but I do see it now on macOS 10.13.

xdiskusage works by parsing the output of df and du, which can be fragile. 1.51 and earlier, for example, didn't work on recent versions of macOS, for which I ​submitted a fix which appeared in 1.52.

It looks like this problem was introduced in xdiskusage 1.53; 1.52 didn't have this problem.

I'm going to guess that this is fallout from ​this commit which was right after 1.52 was released. There were only two other commits after that before 1.53 was released.

Since this seems like an upstream problem, I ​reported it to the developers so they can fix it.

[ryandesign (Ryan Carsten Schmidt)]

In e1312179d7c192eedbe850daecf489b85e43cce6/macports-ports (master):

xdiskusage: Update to 1.60

Closes: #63422

[q2go]

Thank you very much for taking such quick action and making a fix available even faster than I needed it (which is today)! You and upstream rock!

(Are such "thank you!" comments appreciated here in the MacPorts Trac or rather frowned upon due to the additional notifications they create?)