Opened 3 years ago
Closed 3 years ago
#63484 closed update (fixed)
updated Portfile for py-pyfftw
Reported by: | bernard-giroux (Bernard Giroux) | Owned by: | lpsinger (Leo Singer) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | ||
Port: | py-pyfftw |
Description
I could install an updated version of pyfftw with the attached portfile.
Attachments (2)
Change History (6)
Changed 3 years ago by bernard-giroux (Bernard Giroux)
comment:1 Changed 3 years ago by reneeotten (Renee Otten)
Owner: | set to lpsinger |
---|---|
Status: | new → assigned |
Version: | 2.7.99 |
comment:2 Changed 3 years ago by bernard-giroux (Bernard Giroux)
Hi
I added the flag because otherwise the port does not install. The developers of pyfftw use a custom approach to find the fftw library, and the flag is needed for that purpose.
It looks like they are aware that this flag is needed on macOS to get the port installed, but for now they have not updated their script.
Changed 3 years ago by bernard-giroux (Bernard Giroux)
comment:3 Changed 3 years ago by reneeotten (Renee Otten)
please add the main.log
of a clean, failed build so we can see what the problem is
comment:4 Changed 3 years ago by reneeotten (Renee Otten)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
thanks for the update Bernard! To get this incorporated more quickly, submitting a PR to https://github.com/macports/macports-ports is highly preferred (otherwise you should attached a unified diff). A cursory glance at it shows that you updated the port (good!) but also added
configure.cflags-append -Wno-error=implicit-function-declaration
, not as good ;) We preferable don't want to do that as it just doesn't error out but the problem remains; instead the correct header(s) should be added, or perhaps you added this to get rid of the warnings that MacPorts prints out?