Opened 3 years ago

Closed 18 months ago

#63502 closed defect (fixed)

gtk-osx-application-common-gtk3: error: implicit declaration of function 'SetApplicationDockTileImage' is invalid in C99

Reported by: gagarine (Simon) Owned by: mascguy (Christopher Nielsen)
Priority: Normal Milestone:
Component: ports Version: 2.7.99
Keywords: Cc: cooljeanius (Eric Gallager)
Port: gtk-osx-application-common-gtk3

Description (last modified by mascguy (Christopher Nielsen))

Installing cherrytree fail when installing gtk-osx-application-common-gtk3.

 sudo port install cherrytree +quartz
  ....
  ....
--->  Fetching distfiles for gtk-osx-application-common-gtk3
--->  Attempting to fetch gtk-mac-integration-2.0.8.tar.xz from https://distfiles.macports.org/gtk-osx-application
--->  Verifying checksums for gtk-osx-application-common-gtk3
--->  Extracting gtk-osx-application-common-gtk3
--->  Applying patches to gtk-osx-application-common-gtk3
--->  Configuring gtk-osx-application-common-gtk3
--->  Building gtk-osx-application-common-gtk3           
Error: Failed to build gtk-osx-application-common-gtk3: command execution failed

Details:

:info:build gtk-mac-dock.c:322:7: error: implicit declaration of function 'SetApplicationDockTileImage' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build       SetApplicationDockTileImage (image);
:info:build       ^
:info:build gtk-mac-menu.c:81:3: error: implicit declaration of function 'FlashMenuBar' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build   FlashMenuBar (last_menu_id + 1);
:info:build   ^
:info:build gtk-mac-menu.c:167:3: error: implicit declaration of function 'DisposeMenu' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build   DisposeMenu (menu->menu);
:info:build   ^
:info:build gtk-mac-menu.c:227:3: error: implicit declaration of function 'DeleteMenuItem' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build   DeleteMenuItem (menu_item->menu, menu_item->index); //Clean up the Carbon Menu
:info:build   ^
:info:build gtk-mac-dock.c:367:7: error: implicit declaration of function 'OverlayApplicationDockTileImage' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build       OverlayApplicationDockTileImage (image);
:info:build       ^
:info:build gtk-mac-menu.c:343:9: error: implicit declaration of function 'GetMenuItemProperty' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build   err = GetMenuItemProperty (carbon_item->menu, carbon_item->index,
:info:build         ^
:info:build gtk-mac-menu.c:389:9: error: implicit declaration of function 'ChangeMenuItemAttributes' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build   err = ChangeMenuItemAttributes (carbon_item->menu, carbon_item->index,
:info:build         ^
:info:build gtk-mac-dock.c:371:5: error: implicit declaration of function 'RestoreApplicationDockTileImage' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build     RestoreApplicationDockTileImage ();
:info:build     ^
:info:build gtk-mac-dock.c:415:3: error: implicit declaration of function 'NMRemove' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build   NMRemove (&request->nm_request);
:info:build   ^
:info:build gtk-mac-dock.c:435:7: error: implicit declaration of function 'NMInstall' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build   if (NMInstall (&request->nm_request) != noErr)
:info:build       ^
:info:build gtk-mac-dock.c:458:5: error: implicit declaration of function 'NMRemove' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build     NMRemove (&request->nm_request);
:info:build     ^
:info:build gtk-mac-menu.c:392:11: error: implicit declaration of function 'ChangeMenuAttributes' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build     err = ChangeMenuAttributes (carbon_item->submenu,
:info:build           ^
:info:build gtk-mac-menu.c:403:3: error: implicit declaration of function 'CheckMenuItem' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build   CheckMenuItem (carbon_item->menu, carbon_item->index, active);
:info:build   ^
:info:build gtk-mac-menu.c:419:13: error: implicit declaration of function 'SetMenuItemHierarchicalMenu' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build       err = SetMenuItemHierarchicalMenu (carbon_item->menu,
:info:build             ^
:info:build gtk-mac-menu.c:425:9: error: implicit declaration of function 'CreateNewMenu' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build   err = CreateNewMenu (++last_menu_id, 0, &carbon_item->submenu);
:info:build         ^
:info:build gtk-mac-menu.c:431:9: error: implicit declaration of function 'SetMenuTitleWithCFString' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build   err = SetMenuTitleWithCFString (carbon_item->submenu, cfstr);
:info:build         ^
:info:build gtk-mac-menu.c:435:9: error: implicit declaration of function 'SetMenuItemHierarchicalMenu' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build   err = SetMenuItemHierarchicalMenu (carbon_item->menu, carbon_item->index,
:info:build         ^
:info:build gtk-mac-menu.c:453:9: error: implicit declaration of function 'SetMenuItemTextWithCFString' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build   err = SetMenuItemTextWithCFString (carbon_item->menu, carbon_item->index,
:info:build         ^
:info:build gtk-mac-menu.c:478:13: error: implicit declaration of function 'SetMenuItemModifiers' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build       err = SetMenuItemModifiers (carbon_item->menu, carbon_item->index,
:info:build             ^
:info:build gtk-mac-menu.c:481:13: error: implicit declaration of function 'ChangeMenuItemAttributes' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build       err = ChangeMenuItemAttributes (carbon_item->menu, carbon_item->index,
:info:build             ^
:info:build gtk-mac-menu.c:484:13: error: implicit declaration of function 'SetMenuItemCommandKey' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build       err = SetMenuItemCommandKey (carbon_item->menu, carbon_item->index,
:info:build             ^
:info:build gtk-mac-menu.c:502:9: error: implicit declaration of function 'SetMenuItemCommandKey' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build   err = SetMenuItemCommandKey (carbon_item->menu, carbon_item->index,
:info:build         ^
:info:build gtk-mac-menu.c:517:9: error: implicit declaration of function 'SetMenuItemModifiers' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build   err = SetMenuItemModifiers (carbon_item->menu, carbon_item->index,
:info:build         ^
:info:build gtk-mac-menu.c:670:9: error: implicit declaration of function 'InsertMenuItemTextWithCFString' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build   err = InsertMenuItemTextWithCFString (carbon_menu, cfstr, index - 1,
:info:build         ^

Change History (12)

comment:1 Changed 3 years ago by gagarine (Simon)

It also fail without the quartz variant

 sudo port install cherrytree
--->  Computing dependencies for cherrytree
The following dependencies will be installed: 
 gspell
 gtkmm3
 gtksourceview3
 gtksourceviewmm3
 iso-codes
 libfmt
 libxmlxx2
 makeicns
 pangomm
 spdlog
 uchardet
Continue? [Y/n]: Y
--->  Fetching archive for gtksourceview3
--->  Attempting to fetch gtksourceview3-3.24.11_1.darwin_20.arm64.tbz2 from https://packages.macports.org/gtksourceview3
--->  Attempting to fetch gtksourceview3-3.24.11_1.darwin_20.arm64.tbz2.rmd160 from https://packages.macports.org/gtksourceview3
--->  Installing gtksourceview3 @3.24.11_1
Warning: gtk3 must be installed with +x11.
--->  Activating gtksourceview3 @3.24.11_1
--->  Cleaning gtksourceview3
--->  Fetching archive for iso-codes
--->  Attempting to fetch iso-codes-4.7.0_0.darwin_20.noarch.tbz2 from https://packages.macports.org/iso-codes
--->  Attempting to fetch iso-codes-4.7.0_0.darwin_20.noarch.tbz2.rmd160 from https://packages.macports.org/iso-codes
--->  Installing iso-codes @4.7.0_0
--->  Activating iso-codes @4.7.0_0
--->  Cleaning iso-codes
--->  Fetching archive for gspell
--->  Attempting to fetch gspell-1.8.4_1.darwin_20.arm64.tbz2 from https://packages.macports.org/gspell
--->  Attempting to fetch gspell-1.8.4_1.darwin_20.arm64.tbz2 from https://fra.de.packages.macports.org/gspell
--->  Attempting to fetch gspell-1.8.4_1.darwin_20.arm64.tbz2 from https://nue.de.packages.macports.org/gspell
--->  Fetching distfiles for gspell
--->  Attempting to fetch gspell-1.8.4.tar.xz from https://distfiles.macports.org/gspell
--->  Verifying checksums for gspell
--->  Extracting gspell
--->  Applying patches to gspell
--->  Configuring gspell
Error: Failed to configure gspell: gtk3 must be installed with +x11.
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_gnome_gspell/gspell/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.
Error: Processing of port cherrytree failed

comment:2 Changed 3 years ago by gagarine (Simon)

Port: cherrytree added; gtk-osx-application-common-gtk3 removed

comment:3 Changed 3 years ago by kencu (Ken)

Port: gtk-osx-application-common-gtk3 added; cherrytree removed
Summary: Error: Failed to build gtk-osx-application-common-gtk3: command execution failedgtk-osx-application-common-gtk3: error: implicit declaration of function 'SetApplicationDockTileImage' is invalid in C99

comment:4 Changed 3 years ago by kencu (Ken)

for your second issue, macports is trying to tell you what is wrong:

gtk3 must be installed with +x11

so do that:

sudo port -f deactivate gtk3
sudo port install gtk +x11

and try again. If you see the same kind of x11 error in other ports after that, do the same thing.

Don't forget you need an x11 server to view x11 software, either xorg-server from macports or XQuartz.

comment:5 Changed 3 years ago by gagarine (Simon)

I realize their is no maintainer for port gtk-osx-application-common-gtk3. Their is still chance it could be fixed?

@kencu thanks, I was able to install cherrytree +x11 and then installed xorg-server from macports. I'm able to run cherrytree but the interface is not usable (fonts are blurry, windows is in dark mode but flicker to light mode when on dual screen, windows resize lag like windows 95, etc.. ). I'm sure their is a way to run X11 on MacOS but life is too short for that, I would rather help testing a quartz version.

comment:6 Changed 3 years ago by kencu (Ken)

oh, x11 works great for me, 100% perfect, but I haven't seen what it looks like on an M1.

Perhaps if you uninstall macports' xorg-server and then install XQuartz from here https://github.com/XQuartz/XQuartz/releases/download/XQuartz-2.8.1/XQuartz-2.8.1.dmg you will have greater happiness.

We know what the implicit declaration of function issue is all about; just have to get someone to find the time to fix it.

comment:7 Changed 3 years ago by kencu (Ken)

well, I took a look, but it just built through as expected on BigSur Intel:

% port -v installed  gtk-osx-application-common-gtk3
The following ports are currently installed:
  gtk-osx-application-common-gtk3 @2.0.8_0 (active) requested_variants='' platform='darwin 20' archs='x86_64' date='2021-09-18T16:26:35-0700'

so, not sure yet why it exactly failed.

comment:8 Changed 3 years ago by kencu (Ken)

sorry, can't get far enough to try to build it universal, so I'm out. Given that it does build for me on BigSur Intel, might be worth just trying again:

sudo port clean gtk-osx-application-common-gtk3
sudo port -v install gtk-osx-application-common-gtk3

comment:9 Changed 3 years ago by gagarine (Simon)

Thanks for your help. As you suggested, I tried to reinstall gtk-osx-application-common-gtk3 on my M1.

First time it failed because gtk3 was not using the +quartz variant (I had gtk3 uninstalled, but perhaps not cleaned?)

Second time I first installed gtk3 +quartz (with success). But when I installed gtk-osx-application-common-gtk3 it failed again with the same errors of my original post :/.

Last edited 3 years ago by gagarine (Simon) (previous) (diff)

comment:10 Changed 3 years ago by cooljeanius (Eric Gallager)

Cc: cooljeanius added

comment:11 Changed 18 months ago by mascguy (Christopher Nielsen)

Description: modified (diff)
Owner: set to mascguy
Status: newassigned

comment:12 Changed 18 months ago by mascguy (Christopher Nielsen)

Resolution: fixed
Status: assignedclosed

Upstream made significant modifications as of version 3.x, and most of the source files with compilation errors no longer exist. Ditto for the undeclared identifiers, which don't appear to exist either.

So let's close this. Please let us know whether all is well!

Note: See TracTickets for help on using tickets.