Opened 3 years ago
Closed 3 years ago
#63529 closed defect (fixed)
opencolorio: fix compatibility with yaml-cpp-0.7.0
Reported by: | devernay (Frédéric Devernay) | Owned by: | devernay (Frédéric Devernay) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.7.1 |
Keywords: | Cc: | MarcusCalhoun-Lopez (Marcus Calhoun-Lopez), cooljeanius (Eric Gallager) | |
Port: | opencolorio |
Description
The upgrade of yaml-cpp broke OCIO 1.1.1 (please don't upgrade to OCIO 2.0 which is a major API change, see if we can have both installed simultaneously).
The fix is simple, but I don't have the time to do a PR, so I'm just filing a ticket for now. line 1408 of src/core/OCIOYaml.cpp, change
if(node["ocio_profile_version"] == NULL)
to
if(!node["ocio_profile_version"])
(it's even backward-compatible with yaml-cpp 0.6.3)
Change History (4)
comment:1 Changed 3 years ago by cooljeanius (Eric Gallager)
Cc: | cooljeanius added |
---|
comment:2 Changed 3 years ago by cooljeanius (Eric Gallager)
comment:3 Changed 3 years ago by devernay (Frédéric Devernay)
OK, now I have a few minutes! I pushed a PR with the above fix: https://github.com/macports/macports-ports/pull/12467
comment:4 Changed 3 years ago by devernay (Frédéric Devernay)
Owner: | set to devernay |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
Note that this breaks rev-upgrade of opencolorio, and blocks installation of blender, as per #62891