Opened 3 years ago

Closed 3 years ago

#63684 closed enhancement (fixed)

GitUp @1.2: remove Sparkle updater

Reported by: cooljeanius (Eric Gallager) Owned by: Knapoc <Knapoc@…>
Priority: Normal Milestone:
Component: ports Version: 2.7.1
Keywords: Cc: Knapoc
Port: GitUp

Description

GitUp tries to update itself via Sparkle when launched. Ports should just rely on MacPorts as the way for users to update them instead. There are other ports that remove Sparkle, too, that you can study to copy.

Change History (4)

comment:1 Changed 3 years ago by Knapoc

Could you please provide more info? Did you install from source? Which OS? Actually sparkle should be disabled already. And provide the output from defaults read co.gitup.mac.

Last edited 3 years ago by Knapoc (previous) (diff)

comment:2 Changed 3 years ago by cooljeanius (Eric Gallager)

I'm on Big Sur (11.6.1) with Xcode 13.1, and I forget whether I built from source or not. All I know is that I saw the Sparkle pop-up on first run; I can't seem to get it to trigger again, though... defaults read co.gitup.mac says:

$ defaults read co.gitup.mac
{
    DisableSparkle = 1;
    FirstLaunch = 0;
    GARawTrackerClientID = "CBF23234-7B22-47F7-8B1F-6941F575EEC9";
    NSNavLastRootDirectory = "~/Documents";
    NSNavPanelExpandedSizeForOpenMode = "{800, 448}";
    "NSWindow Frame NSNavPanelAutosaveName" = "496 485 800 448 0 0 1792 1095 ";
    "NSWindow Frame SUUpdateAlertSmall" = "586 751 620 169 0 0 1792 1095 ";
    "NSWindow Frame preferences" = "559 473 500 350 0 0 1792 1095 ";
    SUAutomaticallyUpdate = 1;
    SUEnableAutomaticChecks = 0;
    SUHasLaunchedBefore = 1;
    SULastCheckTime = "2021-10-27 06:16:52 +0000";
    SUSendProfileInfo = 0;
    SUSkippedVersion = 1038;
    SkipInstallCLT = 1;
    Theme = systemTheme;
}

comment:3 Changed 3 years ago by Knapoc

Thanks for the report. I just analyzed it a bit and fount out, that the respective defaults key (DisableSparkle) was not set until the application was launched. This is the reason, the update prompt appeared when defaults domain co.gitup.mac does not exist or the key was missing.

I submitted a PR which should remove sparkle completely and does not depend on the defaults logic.

comment:4 Changed 3 years ago by Knapoc <Knapoc@…>

Owner: set to Knapoc <Knapoc@…>
Resolution: fixed
Status: newclosed

In 761da34a1a46c464a95a8fd1d0edac3ce10901bc/macports-ports (master):

GitUp: update patch to remove sparkle

  • updates the patch to remove sparkle for good
  • fixes maintainer handle

Closes: #63684

Note: See TracTickets for help on using tickets.