Opened 3 years ago

Closed 3 years ago

#63808 closed defect (fixed)

GitUp @1.1.3: error: use of undeclared identifier 'NSBackgroundStyleEmphasized'

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: Knapoc
Priority: Normal Milestone:
Component: ports Version: 2.7.99
Keywords: highsierra Cc:
Port: GitUp

Description

GitUp @1.1.3 doesn't build on High Sierra.

/opt/local/var/macports/build/_Users_rschmidt_macports_macports-ports-ryandesign-fork_devel_GitUp/GitUp/work/GitUp-1.1.3/GitUpKit/Utilities/GIAppKit.m:280:30: error: use of undeclared identifier 'NSBackgroundStyleEmphasized'; did you mean 'NSBackgroundStyleRaised'?
      if (backgroundStyle == NSBackgroundStyleEmphasized) {
                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
                             NSBackgroundStyleRaised

Attachments (1)

main.log.bz2 (19.2 KB) - added by ryandesign (Ryan Carsten Schmidt) 3 years ago.

Download all attachments as: .zip

Change History (4)

Changed 3 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: main.log.bz2 added

comment:1 Changed 3 years ago by Knapoc

Ah yeah it seems that with version 1.1's dark mode support macOS 10.14 is needed to build the project. Since the Mojave build also seems to fail and maintaining/testing the port for platforms I'm not using is too time consuming, I'm considering dropping support for versions below Big Sur. Thanks for the report though.

comment:2 Changed 3 years ago by ryandesign (Ryan Carsten Schmidt)

That would be fine, just make the port exit early and print a helpful message (and set known_fail yes) on OS versions where it will not build; see other ports for examples.

comment:3 Changed 3 years ago by Knapoc <Knapoc@…>

Resolution: fixed
Status: assignedclosed

In cafdf740ac953f89823c1a4edd281b58c2406646/macports-ports (master):

GitUp: drop support below macOS Big Sur

Closes: #63808

Note: See TracTickets for help on using tickets.