Opened 3 years ago
Last modified 3 years ago
#63821 assigned defect
macportsbot: exceeds maximum number of mentions per comment
| Reported by: | chrstphrchvz (Christopher Chavez) | Owned by: | admin@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | server/hosting | Version: | |
| Keywords: | Cc: | l2dy (Zero King) | |
| Port: |
Description
GitHub appears to limit the number of mentioned handles per comment to 50; so in comments such as https://github.com/macports/macports-ports/pull/12807#issuecomment-961405770, I would think only the first 50 maintainers were successfully pinged. Should macportsbot split up notification comments to limit the number of notified maintainers per comment?
Change History (3)
comment:1 Changed 3 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | l2dy added |
|---|
comment:2 Changed 3 years ago by l2dy (Zero King)
I was worried about contributors who are not familiar with Git open a pull request with a lot of rebased commits and accidentally ping a lot of maintainers, but this shouldn't be a problem now.
We welcome contributions to the bot, related code is https://github.com/macports/mpbot-github/blob/a79d1c86e4e9cc5daa284107132140f9c52b6cd7/pr/webhook/pull_request.go#L119-L132.
comment:3 Changed 3 years ago by chrstphrchvz (Christopher Chavez)
Thanks for pointing me to the relevant code. I’m not familiar with Go, but here is a completely untested attempt: https://github.com/macports/mpbot-github/pull/8
I believe the code is here: https://github.com/macports/mpbot-github; I know nothing about it.