libzzip @0.13.72_0: Build failure with GCC 4.2 (unrecognized command line option "-Warray-bounds")

[evanmiller (Evan Miller)]

:info:build [  0%] Building C object zzip/CMakeFiles/libzzipfseeko.dir/fseeko.c.o
:info:build cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_archivers_libzzip/libzzip/work/build/zzip && /opt/local/bin/gcc-apple-4.2 -DHAVE_CONFIG_H -Dlibzzipfseeko_EXPORTS -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_archivers_libzzip/libzzip/work/zziplib-0.13.72 -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_archivers_libzzip/libzzip/work/build -isystem /opt/local/include -pipe -Os -DNDEBUG -I/opt/local/include -arch ppc -mmacosx-version-min=10.4 -fPIC   -Wpointer-arith -Wsign-compare -Wmissing-declarations -Werror-implicit-function-declaration -Wstrict-aliasing -Warray-bounds -MD -MT zzip/CMakeFiles/libzzipfseeko.dir/fseeko.c.o -MF CMakeFiles/libzzipfseeko.dir/fseeko.c.o.d -o CMakeFiles/libzzipfseeko.dir/fseeko.c.o -c /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_archivers_libzzip/libzzip/work/zziplib-0.13.72/zzip/fseeko.c
:info:build cc1: error: unrecognized command line option "-Warray-bounds"

It looks like either zzip/CMakeLists.txt needs a patch or the Portfile needs to blacklist GCC 4.

[mojca (Mojca Miklavec)]

Upstream report: ​https://github.com/gdraheim/zziplib/issues/129

[mojca (Mojca Miklavec)]

I don't mind if we unconditionally remove that flag (for everyone) with a link to the relevant (upstream?) ticket until a better patch gets written. Unless I misunderstand, the flag is only used to emit more verbose compiler warnings.

[evanmiller (Evan Miller)]

@mojca Sounds right to me.

[ballapete (Peter "Pete" Dyballa)]

With my patch libzzip built – with Python 3.8. make check did not succeed:

INFO:test:ERR 
.ssssss.INFO:test:OUT 
INFO:test:ERR did not open tmp.test_65461/c005-bus-zzip_parse_root_directory: tmp.test_65461/c005-bus-zzip_parse_root_directory: Illegal byte sequence

.........sERROR:test:FIXME: unzip-mem test_65485 is not solved
sssssssssssssssssss.s
======================================================================
FAIL: test_65440 (__main__.ZZipTest)
info unzip -l $(CVE).zip
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_archivers_libzzip/libzzip/work/zziplib-0.13.72/test/zziptests.py", line 3231, in test_65440
    self.assertLess(len(run.output), 500)
AssertionError: 651 not less than 500

----------------------------------------------------------------------
Ran 227 tests in 186.321s

FAILED (failures=1, skipped=27)

[ballapete (Peter "Pete" Dyballa)]

Patch to remove the inadequate compiler option -Warray-bounds

[ballapete (Peter "Pete" Dyballa)]

For me the build fails on PPC Tiger (Mac OS X 10.4.11) and Leopard (Mac OS X 10.5.8). Later today I'll try my patch on Leopard.

[ballapete (Peter "Pete" Dyballa)]

It built with the patch on PPC Leopard, Mac OS X 10.5.8.

[barracuda156]

Replying to ballapete:

For me the build fails on PPC Tiger (Mac OS X 10.4.11) and Leopard (Mac OS X 10.5.8). Later today I'll try my patch on Leopard.

It builds on Tiger without patches when using gcc7 instead of gcc-4.2.