qca-qt5: error: no member named 'toSecsSinceEpoch' in 'QDateTime'

[chrstphrchvz (Christopher Chavez)]

​https://build.macports.org/builders/ports-10.8_x86_64-builder/builds/67452/steps/install-port/logs/stdio

/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_qca/qca-qt5/work/qca-2.3.4/src/qca_default.cpp:1253:22: error: no member named 'toSecsSinceEpoch' in 'QDateTime'; did you mean 'toMSecsSinceEpoch'?
        uint t = now.toSecsSinceEpoch();
                     ^~~~~~~~~~~~~~~~
                     toMSecsSinceEpoch
/opt/local/libexec/qt5/lib/QtCore.framework/Headers/qdatetime.h:254:12: note: 'toMSecsSinceEpoch' declared here
    qint64 toMSecsSinceEpoch() const;
           ^

QCA 2.3.4 migrated to using QDateTime::toSecsSinceEpoch(), which was ​added in Qt 5.8. However Qt 5.7 is the latest version working on macOS 10.8 Mountain Lion.

[RJVB (René Bertin)]

Thanks for this, I was hoping there wouldn't be too many of these. Could you replace the file

`port dir qca`/files/qt5/patch-support-older-qt5.diff

with the version I've attached, do a port clean qca and try again, please?

[chrstphrchvz (Christopher Chavez)]

I should point out, I am merely reporting this on behalf of the builders. I do not use an affected Qt5/macOS version combination.

[RJVB (René Bertin)]

Neither do I, so I stand by the "thanks for this".

I don't get the builder message and I remember from when I did that finding the errors therein was always a real quest. So if you catch more of them, please don't hesitate to transmit them via email directly if that's easier for you.

[mascguy (Christopher Nielsen)]

Replying to RJVB:

Thanks for this, I was hoping there wouldn't be too many of these. Could you replace the file

`port dir qca`/files/qt5/patch-support-older-qt5.diff

with the version I've attached, do a port clean qca and try again, please?

I'll test this on my macOS 10.8 VM, when I can find some time. Will report back with the results.

[chrstphrchvz (Christopher Chavez)]

Off topic:

Replying to RJVB:

I don't get the builder message and I remember from when I did that finding the errors therein was always a real quest.

I found this error by browsing ​https://ports.macports.org/port/qca-qt5/builds/, just to confirm which macOS versions are affected by #63980. The only other ways I look for build failures are either ​https://ports.macports.org/all_builds/, or by browsing merged commits on GitHub (there is an indicator next to each commit, which when clicked will show the status of any resulting builder jobs and a link to them). I do not know how to navigate ​https://build.macports.org/ itself usefully.

So if you catch more of them, please don't hesitate to transmit them via email directly if that's easier for you.

I would like to refrain from corresponding with maintainers privately, as I have often benefited from others reporting/investigating issues publicly—even for small ones seemingly not worth the effort of issue tracker tickets/pull requests. For me, email does not happen to be significantly easier to use.

[mascguy (Christopher Nielsen)]

Rene, I tried building qca-qt5 on macOS 10.8 - with your latest patch - but it failed due to rand() (per issue:63980).

Logs attached; filename: qca-qt5-build-10.8.log.xz

[RJVB (René Bertin)]

It's becoming a bit complicated ... you should have included the fix from ​https://github.com/macports/macports-ports/pull/13010/ (I think, I haven't double-checked your logfile to see if maybe you found another location!)

[RJVB (René Bertin)]

What I mentioned about building against Qt 5.6.3 was wrong (thanks to headers from Qt 5.9, which apparently can be used to solve all the additional issues I found afterwards).

I've attached a new version of the patchfile, this time with verified building of the entire port with all its plugins against Qt 5.6.3 .

FWIW, I can't push this new version to the repo, I'll leave that to a charitable soul :)

[RJVB (René Bertin)]

In 6c0012c9bc722ea575873958c267d3fe8ababa68/macports-ports (master):

qca-qt5: patch to support 10.7 and 10.8
Fixes: #63983