pwait @20210121_0: error: expected parameter declarator

[chrstphrchvz (Christopher Chavez)]

The build fails on 10.7 because the __FBSDID() macro isn’t defined by <sys/cdefs.h> prior to the 10.8 SDK (and only for compatibility—the definition is empty). The error message is from clang trying to interpret the macro usage as a function declaration. ​https://build.macports.org/builders/ports-10.7_x86_64-builder/builds/78913/steps/install-port/logs/stdio

pwait.c:35:10: error: expected parameter declarator
__FBSDID("$FreeBSD$");
         ^
pwait.c:35:10: error: expected ')'
pwait.c:35:9: note: to match this '('
__FBSDID("$FreeBSD$");
        ^
pwait.c:35:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
__FBSDID("$FreeBSD$");
^~~~~~~~
1 warning and 2 errors generated.

Maybe this is something to easily put in legacysupport, unless this is too simple to be worth the effort. A few other ports work around the same issue: rpcgen-mt, developer_cmds, libpdel, bsdiff, fortune,

[ryandesign (Ryan Carsten Schmidt)]

In 1c0f22053d52aac420c2082f38277434d01672e0/macports-ports (master):

pwait: Fix build on Mac OS X 10.7 and earlier

Closes: #64215