Opened 3 years ago
Closed 3 years ago
#64566 closed update (fixed)
podofo @0.9.6_4 : Please update podofo to 0.97.
Reported by: | MrB74 | Owned by: | dbevans (David B. Evans) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.7.1 |
Keywords: | Cc: | ||
Port: | podofo |
Description
Podofo 0.97 was released on January 9th 2021 http://podofo.sourceforge.net/
As developer of Scribus, as we move a version with Qt6 compatibility, we need C++17 support, which podofo 0.97 brings and 0.9.6_4 does not due to std::auto_ptr usage.
Would you be able to update the podofo port please?
thanks Craig (cbradney@…)
Attachments (1)
Change History (7)
comment:1 Changed 3 years ago by reneeotten (Renee Otten)
Keywords: | podofo removed |
---|---|
Owner: | set to dbevans |
Status: | new → assigned |
Version: | → 2.7.1 |
comment:2 Changed 3 years ago by MrB74
comment:4 Changed 3 years ago by reneeotten (Renee Otten)
the port builds also fine for me locally with the Portfile you attached. However I can't really find anywhere upstream that a C++17 compatible compiler is required to compile this package. In fact, the README says that it's tested with
gcc 4.0 [Mac OS X 10.4.10] ("Unix Makefiles" target)
which most likely doesn't support c++17 - correct? So does this really *need* this to build or can we use an Apple clang version on older systems (I see the current Portfile requests already a C++11 compiler though, which I cannot also not find upstream).
Admittedly, I don't know anything about this port but given that only scribus
and scribus-devel
depend on it should make it pretty easy to update... @dbevans hasn't been active for a while although more recently he's committing again. If you could comment on the question above I am happy to submit this as a PR tomorrow and if there is no response from Dave, I'll merge this before the weekend.
comment:5 Changed 3 years ago by MrB74
You may not need to compile podofo with C++17 so feel free to change that in the Portfile back to c++11 (, however 0.97 enables C++17 usage by the removal of std::auto_ptr when std::unique_ptr is available. which became available in C++11 so C++11 is the minimum, as described at https://sourceforge.net/p/podofo/tickets/17/. Their revision r2007 is in the list at https://sourceforge.net/p/podofo/code/commit_browser.
Thanks for helping out!
comment:6 Changed 3 years ago by reneeotten (Renee Otten)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Hi
any updates for this one please? I am attaching a Portfile that worked for me, although patching offsets might need changing. Removed the cmake patch, changed to C++17, adjusting checksums and filenames
thanks
Craig