Opened 3 years ago
Closed 3 years ago
#64629 closed update (fixed)
protozero: Update to 1.7.1
Reported by: | SiggyF | Owned by: | frankdean |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.7.1 |
Keywords: | Cc: | ||
Port: | protozero |
Description
This ports needs an update to 1.7.1 to get working with m1 mac, as described in https://github.com/mapbox/protozero/issues/107.
There is also another issue, which I could fix by editing the cmake settings. The problem is that by default -werror
is used combined with -std=c++11.
/opt/local/include/google/protobuf/parse_context.h:365:3: error: use of the 'nodiscard' attribute is a C++17 extension [-Werror,-Wc++17-extensions] PROTOBUF_NODISCARD const char* AppendString(const char* ptr,
If I set WERROR:BOOL=OFF
the build completes with clang++ . Another option would be to change the -std=c++11 to -std=c++17, but I could not find where to put that in the cmake settings.
Change History (3)
comment:1 Changed 3 years ago by ryandesign (Ryan Carsten Schmidt)
Owner: | set to frankdean |
---|---|
Status: | new → assigned |
Summary: | Update needed for mac m1 max → protozero: Update to 1.7.1 |
comment:2 Changed 3 years ago by frankdean
I've submitted PR #13937 to update the version and disable treating warnings as errors - https://github.com/macports/macports-ports/pull/13937
comment:3 Changed 3 years ago by frankdean <frankdean@…>
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
We should disable the use of
-Werror
. We should not unnecessarily force the use of newer language standards.