Opened 3 years ago
Closed 3 years ago
#64816 closed update (fixed)
luit: Update to 2.0.20220111
| Reported by: | ThomasDickey (Thomas Dickey) | Owned by: | jeremyhu (Jeremy Huddleston Sequoia) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | |
| Port: | luit |
Description
The portfile for luit is older than the current release.
Attachments (2)
Change History (8)
Changed 3 years ago by ThomasDickey (Thomas Dickey)
comment:1 Changed 3 years ago by ryandesign (Ryan Carsten Schmidt)
| Keywords: | haspatch added |
|---|---|
| Owner: | set to jeremyhu |
| Status: | new → assigned |
| Summary: | update luit → luit: Update to 2.0.20220111 |
Thanks. You're making quite a few changes here: switching the port from X.org's luit 1 to your luit 2, removing Jeremy as maintainer and adding yourself, and making the port no longer openmaintainer. Let's let Jeremy weigh in on those changes before taking action.
It's preferred to attach a diff, rather than a full new Portfile, so that it's easier to see what changes you're proposing. Even better is to submit a pull request which performs automated testing and facilitates easier review and merging.
Changed 3 years ago by ThomasDickey (Thomas Dickey)
| Attachment: | Portfile.diff added |
|---|
diff for port-file
comment:2 follow-up: 3 Changed 3 years ago by ThomasDickey (Thomas Dickey)
Attached diff for port-file.
"X.org's luit 1" was orphaned a few years ago:
https://gitlab.freedesktop.org/xorg/app/luit/-/commit/2aaa5d75f1b92a5383af676dbd7f0998e26023ac
Were you suggesting a pull-request against MacPorts for a single file?
https://github.com/macports/macports-ports.git
(retaining "openmaintainer" is ok - on modifying it, I'd thought that was a group rather than a category).
comment:3 Changed 3 years ago by ryandesign (Ryan Carsten Schmidt)
Replying to ThomasDickey:
Attached diff for port-file.
Thanks.
The description could be improved.
description filter that converts legacy encodings to/from UTF-8
long_description ${name} is a filter that converts terminal I/O \
between legacy encodings and UTF-8.
The maintainers line should include your obfuscated email address and your GitHub handle, in addition to openmaintainer if desired.
maintainers {invisible-island.net:dickey @ThomasDickey}
maintainers {invisible-island.net:dickey @ThomasDickey} openmaintainer
"X.org's luit 1" was orphaned a few years ago:
https://gitlab.freedesktop.org/xorg/app/luit/-/commit/2aaa5d75f1b92a5383af676dbd7f0998e26023ac
Thanks, good to know.
Were you suggesting a pull-request against MacPorts for a single file?
Sure, if that's all you need to modify.
(retaining "openmaintainer" is ok - on modifying it, I'd thought that was a group rather than a category).
The openmaintainer token is described in the "maintainers" section of the Guide at https://guide.macports.org/chunked/reference.html#reference.keywords.
comment:4 Changed 3 years ago by ThomasDickey (Thomas Dickey)
I created a pull-request, using your suggested changes.
On the checklist, I did look at the port test, but since there are no batch tests ("make check" would tell that), I left that unchecked. I test luit with external scripts because the results depend on what locales are installed on the system (doesn't fit in my approach to bundled tests).
comment:5 Changed 3 years ago by ThomasDickey (Thomas Dickey)
The pull request is here https://github.com/macports/macports-ports/pull/14254
comment:6 Changed 3 years ago by ThomasDickey (Thomas Dickey)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
updated port file