libfido2 @1.9.0: fails on 10.6.8 Rosetta

[barracuda156]

[  3%] Generating rs256_pk_new.3
cd /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_security_libfido2/libfido2/work/build/man && cp -f /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_security_libfido2/libfido2/work/libfido2-1.9.0/man/rs256_pk_new.3 .
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_security_libfido2/libfido2/work/build'
[  3%] Built target man_copy
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_security_libfido2/libfido2/work/build'
make: *** [all] Error 2
make: Leaving directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_security_libfido2/libfido2/work/build'
Command failed:  cd "/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_security_libfido2/libfido2/work/build" && /usr/bin/make -j4 -w all VERBOSE=ON 
Exit code: 2
Error: Failed to build libfido2: command execution failed
Error: See /opt/local/var/macports/logs/_opt_PPCSnowLeopardPorts_security_libfido2/libfido2/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there
is a bug.
Error: Processing of port libfido2 failed

[kencu (Ken)]

at least the first set of errors looks pretty trivial to fix.

gcc-4.2 doesn't understand these flags, so just patch them out of the build:

524	:info:build cc1: error: unrecognized command line option "-Wno-unused-result"
525	:info:build cc1: error: unrecognized command line option "-Wsign-conversion"

[barracuda156]

Replying to kencu:

at least the first set of errors looks pretty trivial to fix.

gcc-4.2 doesn't understand these flags, so just patch them out of the build:

524	:info:build cc1: error: unrecognized command line option "-Wno-unused-result"
525	:info:build cc1: error: unrecognized command line option "-Wsign-conversion"

It uses Cmake build system and that makes things difficult. I have tried to patch CmakeLists and even directly modify it after port extract, but it does nothing, Cmake pulls these flags from somewhere. I will try to solve that.

[kencu (Ken)]

remove all these, or at least -Werror

​https://github.com/Yubico/libfido2/blob/38633a23d709810e80ea12f55b33d224bb2e9614/CMakeLists.txt#L267

[kencu (Ken)]

and this one

​https://github.com/Yubico/libfido2/blob/38633a23d709810e80ea12f55b33d224bb2e9614/CMakeLists.txt#L308

[barracuda156]

Replying to kencu:

remove all these, or at least -Werror

​https://github.com/Yubico/libfido2/blob/38633a23d709810e80ea12f55b33d224bb2e9614/CMakeLists.txt#L267

Thank you! I finally made it build, however it took quite a bit more than removing those flags. In particular, few functions in hid_osx.c kept failing, so I used conditional to exclude them for OS < 11. I dunno how crucial it may be to overall functionality, but for the time-being:

36-109% port -v installed libfido2
The following ports are currently installed:
  libfido2 @1.9.0_1 (active) requested_variants='' platform='darwin 10' archs='ppc' date='2022-03-30T07:32:22+0800'

[kencu (Ken)]

Yes, when fixing stuff like this, the immediate error to be fixed almost always just leads to the next error to be fixed, until -- with enough effort and perseverance -- there are none eventually.

And then you have to see if the software actually still works, indeed ;>

[trodemaster (Blake Garner)]

This really looks like it should be closed to me. My preference would be to have minimal patches as this is a security related tool. If it's not working on very old versions of macOS that seems like a non-issue. (I'm the owner of this tic but see no way for me to close it)

[barracuda156]

Replying to trodemaster:

This really looks like it should be closed to me. My preference would be to have minimal patches as this is a security related tool. If it's not working on very old versions of macOS that seems like a non-issue. (I'm the owner of this tic but see no way for me to close it)

It does build now, though does not run. I agree, this can be closed.

I want to fix it properly, and will make a PR if that is ready (and hope it is accepted if shown to work), but I am sure nobody needs the ticket hanging open.

16. S. Alternatively, ticket can be re-assigned to myself.

[barracuda156]

Ah, this I can do from my side.

Assigning to myself.