Opened 3 years ago

Closed 3 years ago

#64956 closed defect (fixed)

KeePassXC: Livecheck believes 2.7.0-beta1 > 2.7.0

Reported by: tenzap Owned by: tenzap
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: mascguy (Christopher Nielsen)
Port: KeePassXC

Description

On keepassXChttps://ports.macports.org/port/keepassxc/details/, livecheck says:

KeePassXC seems to have been updated (port version: 2.7.0, new version: 2.7.0-beta1) 

So it looks like livecheck believes 2.7.0-beta1 > 2.7.0, while in fact 2.7.0 is greater that 2.7.0-beta1

Change History (6)

comment:1 Changed 3 years ago by jmroot (Joshua Root)

Component: websiteports
Keywords: livecheck removed
Port: KeePassXC added

That is how vercmp compares those versions. Betas would have to be excluded by adjusting the livecheck regex in the port.

comment:2 Changed 3 years ago by jmroot (Joshua Root)

Summary: Livecheck believes 2.7.0-beta1 > 2.7.0KeePassXC: Livecheck believes 2.7.0-beta1 > 2.7.0

comment:3 Changed 3 years ago by tenzap

on KeePassXC livecheck is actually inherited from the github portgroup.

Would assigning it to github portgroup be more accurate?

comment:4 Changed 3 years ago by mascguy (Christopher Nielsen)

Cc: mascguy added

comment:5 Changed 3 years ago by mascguy (Christopher Nielsen)

Per the previous comment from @jmroot, the regex needs to be specified as:

# Ignore betas, RCs, etc.
github.livecheck.regex  {([0-9.]+)}

In short, the regex needs to stop at the first dash, if any. But it's often simpler to simply limit the valid characters to numerics and the period, which accomplishes it.

Of note, the example above can't necessarily be used verbatim for every port; it depends on how the authors name releases. But the example above does work for KeePassXC.

comment:6 Changed 3 years ago by tenzap

Owner: set to tenzap
Resolution: fixed
Status: newclosed

In b8311a4733b514729cb0ca087b2ce72df6776a89/macports-ports (master):

KeePassXC: update livecheck regex

Closes: #64956

Note: See TracTickets for help on using tickets.