got-portable (gameoftrees) preliminary attempt at a Portfile

[artkiver (グレェ)]

Hello!

I have given a first stab at creating a Portfile for got (gameoftrees.org) a git compatible, BSD licensed, version control tool.

I am actually not really sure what the process is for submitting a new port, but it seemed as if perhaps creating a Trac ticket before a GitHub PR might make sense?

[ryandesign (Ryan Carsten Schmidt)]

Thanks. New ports and changes to existing ports can be submitted directly as pull requests without filing a Trac ticket first. Changes are easier to review on GitHub and automated CI builds happen for pull requests, enabling us to see whether your submission builds or not without having to download it and try it manually. If you are not comfortable using GitHub, it is acceptable to submit new ports or changes as tickets in Trac.

PortGroup           muniversal 1.0

What makes this require the muniversal portgroup?

platforms           darwin

This line appears twice in your Portfile. Both can be removed as this is now the default.

master_sites        https://gameoftrees.org/releases/portable/

To avoid duplication, the homepage variable can be referenced here:

master_sites        ${homepage}releases/portable/

depends_build       port:automake \

Depending only on automake is suspicious. Normally automake, autoconf and libtool are used together. And normally MacPorts will add these dependencies for you when you specify use_autoreconf yes, which you didn't. Normally you only need these dependencies if you are rebuilding the build system. Are you? Or does this build system use automake in some unusual way? I think the automake dependency can just be removed; it still built fine (in trace mode) when I removed it.

                    port:bison \
                    port:pkgconfig \

Remove the trailing slash after "pkgconfig".

This warning appears when configuring:

Warning: Configuration logfiles contain indications of -Wimplicit-function-declaration; check that features were not accidentally disabled:
  recallocarray: found in got-portable-0.68.1/config.log
  reallocarray: found in got-portable-0.68.1/config.log
  strchr: found in got-portable-0.68.1/config.log

recallocarray and reallocarray are unfamiliar to me. Looks like they are BSD functions that are not in any macOS version. So they should be added to the global exclusion files.

strchr is a standard function but current configure scripts contain a test that deliberately fails to include the required header in order to see how the compiler reacts to that. Since the vintage of the configure script is specific to each project, this Portfile should have the following line added to suppress this warning:

configure.checks.implicit_function_declaration.whitelist-append strchr

[artkiver (グレェ)]

Replying to ryandesign:

Thanks for the recommendations and sanity check! I updated the Portfile with the changes you mentioned, though I am not sure how to go about adding anything to the global exclusion files you mentioned.

Per some of your questions: I think the PortGroup muniversal I had simply copy and pasted from another Portfile I was using as a reference in lieu of a blank template; not sure why I had the platforms darwin mentioned twice, though it's good to know it is no longer needed (IIRC, sometimes I've maybe also seen freebsd, so I am guessing perhaps at one point maybe there was the intention to use darwinports/macports with FreeBSD? I am guessing that is no longer particularly active if so). As for automake, I probably just included it explicitly due to using ​https://git.gameoftrees.org/gitweb/?p=got-portable.git;a=blob_plain;f=README.portable;hb=HEAD as a reference, which mentioned automake as a dependency, though I've confirmed that it builds without issue having that lined removed.

As a matter of chance, having re-read their site, it appears as if the version was updated to 0.69 on April 24th since I submitted the Portfile, so I will update that and submit a new version as well to reflect that update.

[artkiver (グレェ)]

Whoops, got is released under the ISC license, not BSD, corrected (thanks ​https://gameoftrees.org/faq.html !)

[artkiver (グレェ)]

In 81d77f1ba4e904345698351d98e352f49ea82ba8/macports-ports (master):

got: submission (new Portfile) Game of Trees 0.69 (​https://github.com/macports/macports-ports/pull/14722)

Closes: #65059