Opened 3 years ago

Closed 3 years ago

#65166 closed enhancement (fixed)

fzf key bindings in fish not enabled automatically

Reported by: ekovarski Owned by: cardi (calvin ardi)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: fzf

Description (last modified by ryandesign (Ryan Carsten Schmidt))

The instructions during port install are not sufficient to enable the key bindings.

While fish will source the file, ${prefix}/share/fzf/shell/key-bindings.fish, as per the instructions when added to config.fish, the bindings have to be manually enabled by adding the following to ~/.config/fish/functions/fish_user_key_bindings.fish 

function fish_user_key_bindings
	fzf_key_bindings
end

This can save some frustration for the user. The install script for fzf usually handles it for fish but it does not seem to be part of the port.

Change History (4)

comment:1 Changed 3 years ago by jmroot (Joshua Root)

Owner: set to cardi
Status: new → assigned

comment:2 Changed 3 years ago by ryandesign (Ryan Carsten Schmidt)

Description: modified (diff)

comment:3 Changed 3 years ago by cardi (calvin ardi)

Thanks for finding this. I'll add the instructions to the port notes.

The install script for fzf usually handles it for fish but it does not seem to be part of the port.

I believe the best practice for ports is to handle installation/uninstallation within MacPorts and not rely on additional install scripts. I described my rationale here: ​https://github.com/macports/macports-ports/pull/12750#issuecomment-956550039.

comment:4 Changed 3 years ago by cardi (calvin ardi)

Resolution: → fixed
Status: assigned → closed

In ffb8ba3f18a66cb9877615e00c2aafbd1a3c9a01/macports-ports (master):

fzf: update instructions for fish shell

  • cleanup and make formatting consistent

Closes: #65166

Note: See TracTickets for help on using tickets.