libiconv @1.17: ./iconv.c:200: error: duplicate 'static'

[barracuda156]

libtool: compile:  /usr/bin/gcc-4.2 -std=gnu99 -I. -I. -I../include -I./../include -I.. -I./.. -pipe -Os -arch ppc -fvisibility=hidden -DLIBDIR=\"/opt/local/lib\" -DBUILDING_LIBICONV -DBUILDING_LIBCHARSET -DBUILDING_DLL -DENABLE_RELOCATABLE=1 -DIN_LIBRARY -DINSTALLDIR=\"/opt/local/lib\" -DNO_XMALLOC -Dset_relocation_prefix=libiconv_set_relocation_prefix -Drelocate=libiconv_relocate -Drelocate2=libiconv_relocate2 -DHAVE_CONFIG_H -c ./relocatable.c -o relocatable.o >/dev/null 2>&1
In file included from ./iconv.c:121:
./encodings.def:71: warning: initialization from incompatible pointer type
./encodings.def:71: warning: initialization from incompatible pointer type
./iconv.c:200: error: duplicate 'static'
make[1]: *** [iconv.lo] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_textproc_libiconv/libiconv/work/libiconv-1.17-ppc/lib'
make: *** [all] Error 2

[ryandesign (Ryan Carsten Schmidt)]

Does removing patch-c99.diff from the patchfiles line help?

[barracuda156]

Replying to ryandesign:

Does removing patch-c99.diff from the patchfiles line help?

Indeed, it does:

36-111:~ svacchanda$ port -v installed libiconv
The following ports are currently installed:
  libiconv @1.16_1 requested_variants='-universal' platform='darwin 9' archs='ppc' date='2021-12-22T11:50:47+0800'
  libiconv @1.16_1+universal requested_variants='+universal' platform='darwin 9' archs='ppc ppc64' date='2021-12-21T05:52:40+0800'
  libiconv @1.17_0+universal (active) requested_variants='+universal' platform='darwin 9' archs='ppc ppc64' date='2022-05-19T21:32:39+0800'

Thank you.

[ryandesign (Ryan Carsten Schmidt)]

Thanks for confirming. I can reproduce it too, on Catalina when using apple-gcc42. I'll get rid of the patch.

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

The static keyword already ​seems to exist in the upstream source, so is there a need to include it in the patch at all?
There is a ​pull request that attempts to fix the problem.

[ryandesign (Ryan Carsten Schmidt)]

In 7ad0b06e7859da4f4b7b6e9145618b17e929875a/macports-ports (master):

libiconv: Fix build with c89 compilers

Remove patch-c99.diff which was added over a decade ago to fix the build
with c99 compilers. It isn't needed anymore for that purpose -- upstream
must have fixed it another way -- and now it causes build failure with
c89 compilers.

Closes: #65200