Opened 2 years ago
Last modified 11 months ago
#65257 assigned enhancement
rust: large volume of compilation warnings, pollutes build log
Reported by: | mascguy (Christopher Nielsen) | Owned by: | MarcusCalhoun-Lopez (Marcus Calhoun-Lopez) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.7.2 |
Keywords: | Cc: | MarcusCalhoun-Lopez (Marcus Calhoun-Lopez), cjones051073 (Chris Jones), herbygillot (Herby Gillot) | |
Port: | rust |
Description
Presently there appear to be very large number of warnings during compilation of rust
, making it difficult to discern what's important. (Not to mention causing the build logs to be massive.)
Attached is an example, for a build on 10.13.
It might be helpful to reduce these to the bare minimum - or perhaps even eliminate them entirely, if necessary - so that the logs are more manageable.
If the consensus is that such warnings are critical to leave in place, then so be it. But if folks don't have a preference, reducing the verbosity could be beneficial.
Attachments (1)
Change History (8)
Changed 2 years ago by mascguy (Christopher Nielsen)
Attachment: | rust-build-log-10.13.txt.xz added |
---|
comment:1 Changed 2 years ago by herbygillot (Herby Gillot)
Owner: | set to MarcusCalhoun-Lopez |
---|---|
Status: | new → assigned |
comment:2 Changed 2 years ago by cjones051073 (Chris Jones)
comment:3 Changed 2 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Indeed, the first recommendation of C++ Coding Standards is to compiler code "cleanly at high warning levels."
Nearly all of our patches have been merged upstream, so I doubt this is a MacPorts issue.
Also, Rust does not seem to make suppressing warning trivial.
Also also, some of the warnings are from crates and not from Rust itself.
I am inclined to close this ticket since things are behaving as intended.
As needed, we'll have to propose fixes to the various upstream maintainers to compile cleanly.
Any thoughts?
comment:4 Changed 2 years ago by mascguy (Christopher Nielsen)
I was hoping we might be able to handle this via arguments to rustc
, etc, but perhaps it's not that straightforward?
Regardless, this is purely a nice-to-have, to reduce the verbosity of our build logs. So if it's not easy or practical, I'm fine with closing.
Anyone else, thoughts?
comment:5 Changed 2 years ago by mascguy (Christopher Nielsen)
Type: | defect → enhancement |
---|
comment:6 Changed 2 years ago by cjones051073 (Chris Jones)
If not actually addressed we should keep open, to track any discussions we might have with upstream.
comment:7 Changed 11 months ago by halostatue (Austin Ziegler)
This can be turned down by changing
--set=build.verbose=2 \
in configure.args-append
.
# Verbosity level: 0 == not verbose, 1 == verbose, 2 == very verbose, 3 == print environment variables on each rustc invocation
At the moment, I have bumped it to 3 to try to upgrade Rust on my machine at least.
I agree, if the warnings are introduced as a result of patches we created and apply ourselves, then an attempt should be made to supress the warnings as much as possible.