lowdown @1.0.0: make install in build phase?

[ryandesign (Ryan Carsten Schmidt)]

The lowdown port runs make install install_lib_common install_shared (as the macports user) in the build phase, which is unusual, especially since MacPorts will run make install again (as root) in the destroot phase. Usually in the build phase ports run make or make all or some other makefile target that builds the software, leaving the makefile's installation target(s) to be run only in the destroot phase. If this build system is so unusual that it really requires the installation targets to be invoked in the build phase, that should be explained in a portfile comment ideally with a link to the upstream bug report. Also, note that MacPorts adds parallel build flags like -j8 during the build phase but not during the destroot phase because we found that many build systems fail when installing in parallel. So MacPorts will run your make install install_lib_common install_shared during the build phase with the parallel build flags. So far this is not failing on the build machines, so this makefile may be designed to accommodate parallel install, or it could just be luck.

[Vadym-Valdis Yudaiev <judaew@…>]

In aa6ac2543f204505113659c0fa371e40c6a27f91/macports-ports (master):

lowdown: Fix wrong lib name and symlink

Trac:

Fixed #65268
Fixed #65267
Fixed #65266

GitHub:

See ​https://github.com/kristapsdz/lowdown/pull/88
See ​https://github.com/kristapsdz/lowdown/pull/91

[judaew (Vadym-Valdis Yudaiev)]

Thank you, I moved those targets (install_lib_common and install_shared) to destroot.target-append and added a comment. By default, lowdown installs only binaries and docs.