Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#65311 closed defect (fixed)

redis @7.0.1: builds failing for 10.14 and earlier: fatal error: 'jemalloc/jemalloc.h' file not found

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: dgilman (David Gilman)
Priority: Normal Milestone:
Component: ports Version: 2.7.2
Keywords: Cc: mascguy (Christopher Nielsen)
Port: redis

Description

https://build.macports.org/builders/ports-10.11_x86_64-builder/builds/185098/steps/install-port/logs/stdio

/bin/sh: pkg-config: command not found
In file included from quicklist.c:34:
./zmalloc.h:50:10: fatal error: 'jemalloc/jemalloc.h' file not found
#include <jemalloc/jemalloc.h>
         ^

Change History (6)

comment:1 Changed 2 years ago by mascguy (Christopher Nielsen)

Of note, this failure is occurring for macOS 10.14 and earlier. Whereas previously, this port was building essentially across-the-board.

If we can't fix this quickly, I'd like to suggest that this change be reverted.

comment:2 Changed 2 years ago by mascguy (Christopher Nielsen)

Summary: redis @7.0.1: fatal error: 'jemalloc/jemalloc.h' file not foundredis @7.0.1: builds failing for 10.14 and earlier: fatal error: 'jemalloc/jemalloc.h' file not found

comment:3 Changed 2 years ago by mascguy (Christopher Nielsen)

Cc: mascguy added

comment:4 in reply to:  1 Changed 2 years ago by mascguy (Christopher Nielsen)

It looks like a fix is pending, via the following PR. Tested locally on 10.12 through 10.14, and this does the trick:

PR 15092 - redis: only link libatomic on i386

While a minor fix is needed for Universal builds - per an outstanding comment from @ryandesign - otherwise it looks good.

comment:5 Changed 2 years ago by kencu (Ken)

clang doesn’t use libatomic.

It’s a gcc-only thing.

comment:6 Changed 2 years ago by mascguy (Christopher Nielsen)

Resolution: fixed
Status: assignedclosed

Fixed via aforementioned PR; commit:

[96579f7915115798abdd5ff8c69d5d7b3b5464fd/macports-ports]

Last edited 2 years ago by ryandesign (Ryan Carsten Schmidt) (previous) (diff)
Note: See TracTickets for help on using tickets.