putty @0.77 fails to build on mavericks: "error: use of undeclared identifier 'AT_SYMLINK_NOFOLLOW'"

[tehcog (tehcog)]

Please see attached main.log

:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_security_putty/putty/work/putty-0.77/unix/sftpserver.c:607:14: warning: implicit declaration of function 'fstatat' is invalid in C99 [-Wimplicit-function-declaration]
:info:build         if (!fstatat(dirfd(udh->dp), de->d_name, &st, AT_SYMLINK_NOFOLLOW)) {
:info:build              ^
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_security_putty/putty/work/putty-0.77/unix/sftpserver.c:607:55: error: use of undeclared identifier 'AT_SYMLINK_NOFOLLOW'
:info:build         if (!fstatat(dirfd(udh->dp), de->d_name, &st, AT_SYMLINK_NOFOLLOW)) {
:info:build                                                       ^
:info:build 1 warning and 1 error generated.
:info:build make[2]: *** [ssh/CMakeFiles/sshserver.dir/__/unix/sftpserver.c.o] Error 1
:info:build make[2]: *** Waiting for unfinished jobs....

[tehcog (tehcog)]

main.log

[jmroot (Joshua Root)]

Strange that configure correctly finds this:

:info:configure -- Looking for fstatat - not found

and then the code goes ahead and uses that function anyway.

[jmroot (Joshua Root)]

Looks like they're using cmakedefine01 for the fstatat check, which will always define HAVE_FSTATAT to either 0 or 1. But then the code using fstatat is guarded with #if defined HAVE_FSTATAT, which will always be true.

[jmroot (Joshua Root)]

In 0440ca85030b26f73c886a63352537f6a56c5c10/macports-ports (master):

putty: fix build on older systems

Closes: #65327

[ryandesign (Ryan Carsten Schmidt)]

Did this get reported to the developers of putty? If not, please do so.