Opened 2 years ago

Closed 2 years ago

#65712 closed defect (fixed)

dovecot @2.3.19.1: +apns variant is broken

Reported by: essandess (Steve Smith) Owned by: jberry@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: jmroot (Joshua Root)
Port: dovecot

Description (last modified by ryandesign (Ryan Carsten Schmidt))

Commit [301eda8b32a1dc39639a82b71ff0537850462435/macports-ports] makes extensive change to the build process that breaks the build for push notifications, downloads files during the build, introduces patch files that are unnecessary with autoconf, and makes other breaking changes. E.g.,

:info:build Undefined symbols for architecture x86_64:
:info:build   "_cmd_x_apple_push_service", referenced from:
:info:build Undefined symbols for architecture x86_64:
:info:build   "_cmd_x_apple_push_service", referenced from:
:info:build       _imap_ext_commands in imap-commands.o
:info:build       _imap_ext_commands in imap-commands.o
:info:build ld: symbol(s) not found for architecture x86_64
:info:build ld: symbol(s) not found for architecture x86_64
:info:build clang: error: linker command failed with exit code 1 (use -v to see invocation)
:info:build clang: error: linker command failed with exit code 1 (use -v to see invocation)
:info:build make[3]: *** [imap] Error 1
:info:build make[3]: *** Waiting for unfinished jobs....
:info:build make[3]: *** [test-imap-client-hibernate] Error 1
:info:build make[3]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_mail_dovecot/dovecot/work/dovecot-2.3.19.1/src/imap'
:info:build make[2]: *** [all-recursive] Error 1
:info:build make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_mail_dovecot/dovecot/work/dovecot-2.3.19.1/src'
:info:build make[1]: *** [all-recursive] Error 1

I've issued a PR that attempts to undo these changes while keeping other non-breaking changes made in [301eda8b32a1dc39639a82b71ff0537850462435/macports-ports].

Change History (7)

comment:2 Changed 2 years ago by ryandesign (Ryan Carsten Schmidt)

Description: modified (diff)
Keywords: haspatch added

comment:3 Changed 2 years ago by jmroot (Joshua Root)

Owner: set to jberry@…
Status: newassigned

The apns variant may well be broken. But "completely breaks build" is simply not the case; dovecot and dovecot-sieve successfully built on all buildbot workers and are working fine for me locally. The small patches seem preferable to adding all the dependencies for a full autoreconf. I don't see any evidence of files being downloaded during the build, which ones are you referring to?

comment:4 in reply to:  3 ; Changed 2 years ago by essandess (Steve Smith)

Replying to jmroot:

The apns variant may well be broken. But "completely breaks build" is simply not the case; dovecot and dovecot-sieve successfully built on all buildbot workers and are working fine for me locally.

If one relies upon APNS for email, this commit completely breaks the build. The buildbot workers may not use email push notifications, but it sure is useful for humans.

Using autoconf is necessary to apply these patches and produces highly reliable builds.

I don't see any evidence of files being downloaded during the build, which ones are you referring to?

See notes to wget used by upstream in the Portfile, e.g.: https://github.com/dovecot/core/blob/9bf3f37a2dd5526f87aca496b3b44f76fee3f3b6/src/lib/Makefile.am#L33-L34

comment:5 in reply to:  4 Changed 2 years ago by jmroot (Joshua Root)

Summary: dovecot: update to 2.3.19.1, sieve to 0.5.19 completely breaks build, APNSdoveco: @2.3.19.1: +apns variant is broken

Replying to essandess:

Replying to jmroot:

The apns variant may well be broken. But "completely breaks build" is simply not the case; dovecot and dovecot-sieve successfully built on all buildbot workers and are working fine for me locally.

If one relies upon APNS for email, this commit completely breaks the build. The buildbot workers may not use email push notifications, but it sure is useful for humans.

I didn't say we shouldn't fix the variant.

I don't see any evidence of files being downloaded during the build, which ones are you referring to?

See notes to wget used by upstream in the Portfile, e.g.: https://github.com/dovecot/core/blob/9bf3f37a2dd5526f87aca496b3b44f76fee3f3b6/src/lib/Makefile.am#L33-L34

That does nothing because UnicodeData.txt already exists.

comment:6 Changed 2 years ago by jmroot (Joshua Root)

Summary: doveco: @2.3.19.1: +apns variant is brokendovecot @2.3.19.1: +apns variant is broken

comment:7 Changed 2 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.