gtest @1.12.1: builds failing for 10.8 thru 10.10: identifier GTEST_NO_TAIL_CALL_

[mascguy (Christopher Nielsen)]

This port is failing to build for 10.8 thru 10.10, with the following errors:

In file included from gtest/work/googletest-1.12.1/googletest/src/gtest-all.cc:42:
In file included from gtest/work/googletest-1.12.1/googletest/src/gtest-death-test.cc:86:
gtest/work/googletest-1.12.1/googletest/src/gtest-internal-inl.h:636:23:
error: expected ';' at end of declaration list
      GTEST_NO_INLINE_ GTEST_NO_TAIL_CALL_;
                      ^
                      ;

​https://ports.macports.org/port/gtest/details/

Given that builds succeed for 10.6 and 10.7, perhaps this is related to the Cxx standard, and/or chosen compiler.

[Christopher Nielsen <mascguy@…>]

In 82417092f3ec977e71245ca135feed80eb76a7fb/macports-ports (master):

gtest: cxx_std: bump to 2017; set via cmake
See: #65769

[Christopher Nielsen <mascguy@…>]

In 3133dc494488dfe355af65b37419800aba5f1e98/macports-ports (master):

gtest: use legacysupport/macports-libcxx for 10.10 and earlier
Fixes: #65769

[judaew (Vadym-Valdis Yudaiev)]

Thank you Christopher!

[jmroot (Joshua Root)]

Requiring C++17 is a bug according to the ​release notes:

This will be the last release to support C++11. Future releases will require at least C++14.

I guess by definition there won't be a release that fixes the build with C++11, but does it work with cxx_standard 2014? If not, that should be reported upstream.

[mascguy (Christopher Nielsen)]

Replying to jmroot:

Requiring C++17 is a bug according to the ​release notes:

This will be the last release to support C++11. Future releases will require at least C++14.

I guess by definition there won't be a release that fixes the build with C++11, but does it work with cxx_standard 2014? If not, that should be reported upstream.

Retested with standard set to 2014, and looks good. So I'll downgrade.

Thanks for the heads-up Josh!

[Christopher Nielsen <mascguy@…>]

In b823ebf252835a0afc36547b37f35a43b892de91/macports-ports (master):

gtest: cxx_std: downgrade to 2014; 2017 not needed
See: #65769