py-berkeleydb: build failures for 10.10 and earlier, due to use of static_assert

[mascguy (Christopher Nielsen)]

Per past tickets, this may require patching to use _Static_assert. (Along with engaging upstream.)

src/Module/berkeleydb.c:107:15: error: expected parameter declarator
static_assert(sizeof(db_recno_t) == sizeof(u_int32_t),
              ^

[kencu (Ken)]

you might try this, works for me. Haven't got around to adding it to MP yet.

​https://github.com/kencu/kencu-legacy-support/commit/6132fe60d1b9913d959c54823855e12064540a3d

IMHO it's not really an upstream issue, as supporting ancient MacOSX SDKs is really not something we should expect.

Hope it works for you!

[kencu (Ken)]

or some version of that, anyway. looks a touch funny to me when I look at it just now, but it's been a long time since I did it.

[Christopher Nielsen <mascguy@…>]

In dff632e390841865b934966c7ebeb69b7a1efdda/macports-ports (master):

py-berkeleydb: patch for static_assert
Fixes: #65909

[mascguy (Christopher Nielsen)]

Replying to kencu:

you might try this, works for me. Haven't got around to adding it to MP yet.

​https://github.com/kencu/kencu-legacy-support/commit/6132fe60d1b9913d959c54823855e12064540a3d

That would be far preferable to my quick fix, which is to temporarily disable use of static_assert.

Would you be interested in adding to legacy support?

[jmroot (Joshua Root)]

Replying to kencu:

IMHO it's not really an upstream issue, as supporting ancient MacOSX SDKs is really not something we should expect.

Going by discussion around using it in cpython, having a C11 compiler but no static_assert macro is actually pretty common across different platforms.

[kencu (Ken)]

Here you go, mascguy:

[34588ddd014e7d8cd535a1574727f3513babe250/macports-legacy-support]

It is just copied directly out of the assert.h header from an SDK newer than 10.10.

So once a new legacysupport comes out, that should take care of that problem for ... ever.

[mascguy (Christopher Nielsen)]

No longer an issue with later releases, closing.