#66056 closed defect (fixed)
cdo @2.1.0: error: 'TARGET_OS_MACCATALYST' is not defined, evaluates to 0
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | tenomoto (Takeshi Enomoto) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.8.0 |
| Keywords: | lion | Cc: | remkos (Remko Scharroo) |
| Port: | cdo |
Description
cdo_getopt.cc:38:7: error: 'TARGET_OS_MACCATALYST' is not defined, evaluates to 0 [-Werror,-Wundef-prefix=TARGET_OS_]
#elif TARGET_OS_MACCATALYST
^
Change History (7)
comment:1 Changed 2 years ago by kencu (Ken)
comment:2 Changed 2 years ago by reneeotten (Renee Otten)
| Cc: | remkos added; reneeotten removed |
|---|
I merged the PR from Remko yesterday and noticed in the build logs a failure in that it requires C++17. So that's the change I made and probably the build got further now on these older systems and now hit another issue...
I have personally use for this port nor older systems, so I'll leave this to other interested parties ;)
comment:3 Changed 2 years ago by Ken <21211439+kencu@…>
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:4 Changed 2 years ago by kencu (Ken)
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
that addition to legacysupport is just part of the fix needed.
comment:5 Changed 2 years ago by remkos (Remko Scharroo)
Thanks @kencu for your effort. I'm afraid I have no familiarity with legacy support, and no way to test it. So I rely on your experience and expertise. Meanwhile I think the current port stands as is for non-legacy users.
comment:6 Changed 2 years ago by ken-cunningham-webuse
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
comment:7 Changed 2 years ago by kencu (Ken)
this commit does fix cdo on 10.7, at least, however we need a new release of legacysupport before the buildbots will be able to build it.
For now, you can use legacy-support-devel:
sudo port -f deactivate legacy-support sudo port -v install legacy-support-devel sudo port -v install cdo
and that should work for you.
A new release of legacy-support should be coming soon, as there are some changes in there that have been waiting a while to be rolled out now.
looks like yet another to add like this:
https://github.com/macports/macports-legacy-support/commit/8326996229b43802c0eb1f0b1fde3400dc419724
and then make sure legacysupport is used here of course…