nethack: error: too few arguments provided to function-like macro invocation

[ShadSterling (Shad Sterling)]

Build failed while reinstalling all ports after upgrading to Ventura

The problem seems to be a conflict with a macro defined in the SDK

:info:build /usr/bin/clang -Wall -Wextra -Wno-missing-field-initializers -Wimplicit -Wreturn-type -Wunused -Wformat -Wswitch -Wshadow -Wwrite-strings -DGCC_WARN -ansi -pedantic -Wno-long-long -O2 -I../include -DNOMAIL -DNOTPARMDECL -DHACKDIR=\"/opt/local/var/games/nethack\" -DDEFAULT_WINDOW_SYS=\"tty\" -DDLB -DGREPPATH=\"/usr/bin/grep\" -DSYSCF -DSYSCF_FILE=\"/opt/local/var/games/nethack/sysconf\" -DSECURE -c monst.c
:info:build In file included from monst.c:6:
:info:build In file included from ../include/config.h:581:
:info:build In file included from ../include/global.h:9:
:info:build In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/stdio.h:64:
:info:build In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/_stdio.h:68:
:info:build /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/sys/cdefs.h:309:39: error: too few arguments provided to function-like macro invocation
:info:build #if __has_attribute(warn_unused_result)
:info:build                                       ^

[jflude]

Unfortunately I don't (yet) have a Ventura machine but I will be getting one in a few weeks. So I am unable to reproduce right now. However I would think this just needs a very straight forward patch...

[ryandesign (Ryan Carsten Schmidt)]

Replying to jflude:

However I would think this just needs a very straight forward patch...

What might that patch do?

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #66553. jflude, it sounded like you had an idea of how this might be fixed; if so, please share it.

[kencu (Ken)]

​https://github.com/macports/macports-ports/pull/17085

 % port -v installed nethack
The following ports are currently installed:
  nethack @3.6.6_0 (active) requested_variants='' platform='darwin 22' archs='arm64' date='2022-12-27T17:58:45-0800'

[kencu (Ken)]

In 2fcec9af954931269141830fead4bed78dcf66c1/macports-ports (master):

nethack: fix build on Ventura

closes: #66092