Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#66102 closed defect (fixed)

botan @2.19.2: fails at patching stage

Reported by: MaintenanceCosts Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: ventura Cc:
Port: botan

Description

botan fails to install, at the patching stage, during a migration from Monterey to Ventura. It worked fine when I installed it on the Monterey system some time ago. I've tried cleaning and reinstalling botan, and then uninstalling and reinstalling all of MacPorts. No change. main.log is attached.

Attachments (1)

main.log (43.7 KB) - added by MaintenanceCosts 2 years ago.
main.log with error

Download all attachments as: .zip

Change History (7)

Changed 2 years ago by MaintenanceCosts

Attachment: main.log added

main.log with error

comment:1 Changed 2 years ago by MaintenanceCosts

Summary: botan fails at patching stagebotan 2.19.2 fails at patching stage

comment:2 Changed 2 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: ventura added
Summary: botan 2.19.2 fails at patching stagebotan @2.19.2: fails at patching stage

The log shows the problem is:

patching file 'src/build-data/cc/clang.txt'
1 out of 1 hunks failed--saving rejects to 'src/build-data/cc/clang.txt.rej'

The patch applies fine on my Catalina system, with fuzz:

patching file src/build-data/cc/clang.txt
Hunk #1 succeeded at 76 with fuzz 2 (offset 3 lines).
patching file src/build-data/cc/gcc.txt
Hunk #1 succeeded at 89 with fuzz 1 (offset 2 lines).

Several other tickets are revealing to us that the patch utility on Ventura does not support applying patches with fuzz. The patch should be regenerated. Somebody should also report this problem to Apple.

comment:3 Changed 2 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: set to ryandesign
Resolution: fixed
Status: newclosed

In 6e429ef93b54c884174e7b8c58c5d9637d0e5ae9/macports-ports (master):

botan: De-fuzz patch

Closes: #66102

comment:4 in reply to:  2 Changed 2 years ago by jmroot (Joshua Root)

Several other tickets are revealing to us that the patch utility on Ventura does not support applying patches with fuzz. The patch should be regenerated. Somebody should also report this problem to Apple.

I suspect it's WAI, and that's not really a bad thing. Patches with fuzz can "succeed" in applying but produce an incorrect file.

comment:5 Changed 2 years ago by ryandesign (Ryan Carsten Schmidt)

What's WAI?

comment:6 in reply to:  5 Changed 2 years ago by jmroot (Joshua Root)

Replying to ryandesign:

What's WAI?

Working As Intended

Note: See TracTickets for help on using tickets.