Opened 2 years ago
Last modified 11 months ago
#66132 assigned defect
openjdk11-graalvm varies distfile based on configure.build_arch
Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | breun (Nils Breunese) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.8.0 |
Keywords: | Cc: | cooljeanius (Eric Gallager) | |
Port: | openjdk11-graalvm |
Description
openjdk11-graalvm varies which distfile it uses based on configure.build_arch
but the mirroring component of mpbb running on the buildbot doesn't support doing that. As a result, the arm64 distfile never gets mirrored, because the machine doing the mirroring always has configure.build_arch
set to x86_64.
The mirroring script does support varying based on os.arch
however, so I suggest you do that here:
-
java/openjdk11-graalvm/Portfile
diff --git a/java/openjdk11-graalvm/Portfile b/java/openjdk11-graalvm/Portfile index 5199357fb62..9c53d58dd74 100644
a b long_description GraalVM is a universal virtual machine for running applications 23 23 24 24 master_sites https://github.com/graalvm/graalvm-ce-builds/releases/download/vm-${version}/ 25 25 26 if {${configure.build_arch} eq "x86_64"}{26 platform darwin i386 { 27 27 distname graalvm-ce-java11-darwin-amd64-${version} 28 28 checksums rmd160 c0c8bc78bea75f7b8dec958ede569d1ad0263d37 \ 29 29 sha256 b8b39d6a3e3a9ed6348c2776ff071fc64ca90f98999ee846e6ca7e5fdc746a8b \ 30 30 size 254057238 31 } elseif {${configure.build_arch} eq "arm64"} { 31 } 32 platform darwin arm { 32 33 distname graalvm-ce-java11-darwin-aarch64-${version} 33 34 checksums rmd160 0e8e04f543c80044eceac29066522c0d3c5b18f8 \ 34 35 sha256 c9657e902c2ba674931c3cf233a38c4de3d5186ae5d70452f9df75ac0c4cacff \
The only valid values for os.arch
are powerpc, i386, and arm.
This change works here only because this port excludes i386 from supported_archs
so there is only one distfile for Intel. If this port supported both x86_64 and i386, then you would indeed have to choose based on the build arch and there would be no solution for mirroring the i386 files. (It would mirror the x86_64 files.)
Please check your other ports if similar changes are needed there.
Change History (2)
comment:1 Changed 2 years ago by breun (Nils Breunese)
comment:2 Changed 11 months ago by cooljeanius (Eric Gallager)
Cc: | cooljeanius added |
---|
Currently all
openjdk*
ports I maintain haveNoMirror
set, so none of these distfiles should currently get mirrored at all. If via https://trac.macports.org/ticket/66133 we decide these distfiles should be mirrored, then I guess we should also make a change like this.Can this platform syntax also be used for the distile for the
openjdk11-graalvm-native-image
subport?