Opened 2 years ago

Closed 2 years ago

#66329 closed defect (fixed)

gawk sneaks in x86_64 which is not set in universal_archs on Leopard

Reported by: barracuda156 Owned by: Schamschula (Marius Schamschula)
Priority: Normal Milestone:
Component: ports Version: 2.8.0
Keywords: powerpc, leopard, ppc64 Cc: markmentovai (Mark Mentovai)
Port: gawk

Description

Macports is configured to build for ppc+ppc64 when +universal is specified:

universal_archs     	ppc ppc64

Portfile refers to README.macosx, which talks about a specific case of M1. I believe, that should be limited to aarch64 and the following should not happen on PowerPC:

--->  Building gawk
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_gawk/gawk/work/gawk-5.2.1" && /usr/bin/make -j4 -w all 
make: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_gawk/gawk/work/gawk-5.2.1'
/usr/bin/make  all-recursive
make[1]: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_gawk/gawk/work/gawk-5.2.1'
Making all in support
make[2]: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_gawk/gawk/work/gawk-5.2.1/support'
/usr/bin/gcc-4.2 -std=gnu99 -DGAWK -DHAVE_CONFIG_H -I"./.." -I. -I..   -isystem/opt/local/include/LegacySupport -I/opt/local/include -pipe -Os -arch ppc -arch ppc64 -DNDEBUG -arch x86_64 -pipe -Os -arch ppc -arch ppc64 -DNDEBUG -arch x86_64 -c -o dfa.o dfa.c

Change History (3)

comment:1 Changed 2 years ago by markmentovai (Mark Mentovai)

That -arch x86_64 isn’t coming from the Portfile, it’s coming from the upstream gawk build itself. The --disable-pma in the Portfile is what circumvents it. Clearly the upstream had not contemplated ppc or ppc64. In fact, it won’t work for builds intended to be 32-bit x86 either.

I had tried to let the PMA feature work where it could, but based on this report, disabling it when ${build_arch} eq "arm64" isn’t good enough. It really needs to be disabled when ${build_arch} ne "x86_64". Either that, or the PMA feature could just be unconditionally disabled altogether. I’d be in favor of that.

comment:2 Changed 2 years ago by markmentovai (Mark Mentovai)

Cc: markmentovai added

comment:3 Changed 2 years ago by Marius Schamschula <mschamschula@…>

Resolution: fixed
Status: assignedclosed

In 9834c4e2ea63a5355225e66562d0d085c0084bb4/macports-ports (master):

gawk: fix build for PPC, add pma variant

Closes: #66329

Note: See TracTickets for help on using tickets.